Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: report fully drawn (WPB-274) #2204

Merged
merged 2 commits into from Sep 8, 2023
Merged

chore: report fully drawn (WPB-274) #2204

merged 2 commits into from Sep 8, 2023

Conversation

ohassine
Copy link
Member

@ohassine ohassine commented Sep 8, 2023

BugWPB-274 Wire startup time


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Description

This PR aims to use ReportDrawnWhen API to report to the system that the app is ready.

This is recommended by Google as it can improve app startup:

Calling this method when your app is in fully usable state will improve your app startup time. Every application should be using this API! And don’t forget to measure it.

Benchmark:

Before

dev

After

Screenshot 2023-09-08 at 11 34 52

Dependencies (Optional)

If there are some other pull requests related to this one (e.g. new releases of frameworks), specify them here.

Needs releases with:

  • GitHub link to other pull request

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.

Notes (Optional)

Specify here any other facts that you think are important for this issue.

Attachments (Optional)

Attachments like images, videos, etc. (drag and drop in the text box)


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@ohassine ohassine requested review from a team, yamilmedina, alexandreferris, MohamadJaara, mchenani and trOnk12 and removed request for a team September 8, 2023 09:40
@ohassine ohassine added this pull request to the merge queue Sep 8, 2023
@codecov
Copy link

codecov bot commented Sep 8, 2023

Codecov Report

Merging #2204 (fc20894) into develop (b49bf40) will decrease coverage by 0.05%.
Report is 6 commits behind head on develop.
The diff coverage is 0.00%.

@@              Coverage Diff              @@
##             develop    #2204      +/-   ##
=============================================
- Coverage      40.92%   40.87%   -0.05%     
  Complexity       995      995              
=============================================
  Files            310      310              
  Lines          11402    11415      +13     
  Branches        1520     1522       +2     
=============================================
  Hits            4666     4666              
- Misses          6296     6309      +13     
  Partials         440      440              
Files Changed Coverage Δ
...rc/main/kotlin/com/wire/android/ui/WireActivity.kt 0.00% <0.00%> (ø)
...ns/details/editguestaccess/EditGuestAccessState.kt 0.00% <0.00%> (ø)
...etails/editguestaccess/EditGuestAccessViewModel.kt 0.00% <0.00%> (ø)
...nConversation/JoinConversationViaDeepLinkDialog.kt 85.71% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 333a63e...fc20894. Read the comment docs.

📢 Have feedback on the report? Share it here.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 8, 2023

Test Results

600 tests   599 ✔️  7m 11s ⏱️
  85 suites      1 💤
  85 files        0

Results for commit fc20894.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 8, 2023

APKs built during tests are available here. Scroll down to Artifacts!

Merged via the queue into develop with commit 4cfebfd Sep 8, 2023
17 of 18 checks passed
@ohassine ohassine deleted the report_fully_drawn branch September 8, 2023 10:25
@AndroidBob
Copy link
Collaborator

Build 663 succeeded.

The build produced the following APK's:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
5 participants