Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(calling): scrolling the grid is not possible when every one have camera enabled (WPB-4530) (RC) #2221

Merged
merged 1 commit into from
Sep 12, 2023

Conversation

ohassine
Copy link
Member

@ohassine ohassine commented Sep 12, 2023


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

Sister PR of #2220 targeting RC branch


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@ohassine ohassine requested review from a team, typfel, alexandreferris, MohamadJaara, Garzas and trOnk12 and removed request for a team September 12, 2023 11:07
@github-actions
Copy link
Contributor

Test Results

587 tests   586 ✔️  6m 30s ⏱️
  84 suites      1 💤
  84 files        0

Results for commit 82998b1.

@github-actions
Copy link
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

@AndroidBob
Copy link
Collaborator

Build 705 succeeded.

The build produced the following APK's:

@ohassine ohassine merged commit 8073d92 into release/candidate Sep 12, 2023
18 checks passed
@ohassine ohassine deleted the fix_calling_grid_scrolling_rc branch September 12, 2023 12:46
github-actions bot pushed a commit that referenced this pull request Sep 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
4 participants