Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: memory leak related to video renderer (WPB-3953) #2241

Merged
merged 3 commits into from
Sep 18, 2023

Conversation

ohassine
Copy link
Member

@ohassine ohassine commented Sep 15, 2023

BugWPB-3953 [Android] Potential memory leak due to AVS


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

memory leak renderer related to video renderer

Causes (Optional)

In same situation we are not destroying the video renderer, mainly when we leave the calling screen to another screen

Solutions

Destroy renderer when its no longer visible


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@ohassine ohassine requested review from a team, gongracr, yamilmedina, borichellow, Garzas and trOnk12 and removed request for a team September 15, 2023 13:46
@github-actions
Copy link
Contributor

github-actions bot commented Sep 15, 2023

Test Results

607 tests  ±0   606 ✔️ ±0   10m 47s ⏱️ + 4m 28s
  86 suites ±0       1 💤 ±0 
  86 files   ±0       0 ±0 

Results for commit bd3e584. ± Comparison against base commit faa587a.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

@github-actions
Copy link
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

@AndroidBob
Copy link
Collaborator

Build 821 succeeded.

The build produced the following APK's:

@ohassine ohassine changed the title fix: memory leak renderer related to video renderer (WPB-3953) fix: memory leak related to video renderer (WPB-3953) Sep 18, 2023
@ohassine ohassine added this pull request to the merge queue Sep 18, 2023
Merged via the queue into develop with commit ca89841 Sep 18, 2023
16 checks passed
@ohassine ohassine deleted the memory_leak_renderer branch September 18, 2023 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
4 participants