feat: setup app lock screen #2243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build 830 failed. |
Codecov Report
@@ Coverage Diff @@
## develop #2243 +/- ##
=============================================
- Coverage 40.47% 40.45% -0.03%
Complexity 1002 1002
=============================================
Files 315 316 +1
Lines 11549 11555 +6
Branches 1535 1535
=============================================
Hits 4675 4675
- Misses 6435 6441 +6
Partials 439 439
Continue to review full report in Codecov by Sentry.
|
|
APKs built during tests are available here. Scroll down to Artifacts! |
# Conflicts: # app/src/main/kotlin/com/wire/android/ui/home/settings/privacy/PrivacySettingsScreen.kt
|
Build 836 failed. |
|
Build 837 failed. |
|
APKs built during tests are available here. Scroll down to Artifacts! |
|
Build 838 succeeded. The build produced the following APK's: |
MohamadJaara
requested review from
saleniuk,
Garzas,
gongracr,
yamilmedina,
a team and
trOnk12
and removed request for
a team
alexandreferris
approved these changes
Sep 19, 2023
app/src/main/kotlin/com/wire/android/ui/home/appLock/SetLockCodeScreen.kt
Outdated
Show resolved
Hide resolved
…deScreen.kt Co-authored-by: Alexandre Ferris <ferris.alexandre@gmail.com>
|
Build 840 failed. |
MohamadJaara
force-pushed
the
feat/app-lock-setup-screen
branch
from
119766a
to
41b0230
Compare
|
APKs built during tests are available here. Scroll down to Artifacts! |
|
Build 843 succeeded. The build produced the following APK's: |
saleniuk
approved these changes
Sep 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764The PR Description
What's new in this PR?
Issues
add the UI part and navigation for setup app lock feature
Testing
Test Coverage (Optional)
How to Test
Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.
Notes (Optional)
Specify here any other facts that you think are important for this issue.
Attachments (Optional)
Attachments like images, videos, etc. (drag and drop in the text box)
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.