Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(calling): observe self camera state in full screen mode (WPB-4719) #2254

Merged
merged 4 commits into from
Sep 25, 2023

Conversation

ohassine
Copy link
Member

@ohassine ohassine commented Sep 21, 2023

BugWPB-4719 [Android] When maximized self video, turn on/off camera button doesn't work


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

In self full screen tile, the camera state is not updated

Causes (Optional)

We are not observing the state, we are just using the passed state

Solutions

Observe camera and mic state

Dependencies (Optional)

If there are some other pull requests related to this one (e.g. new releases of frameworks), specify them here.

Needs releases with:

  • GitHub link to other pull request

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

  • In a call, make your tile full screen by double tap on it
  • Try to enabled/disable your video

PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 21, 2023

Test Results

611 tests  ±0   610 ✔️ ±0   4m 15s ⏱️ -57s
  88 suites ±0       1 💤 ±0 
  88 files   ±0       0 ±0 

Results for commit 5a2ff7f. ± Comparison against base commit 07c5a7d.

♻️ This comment has been updated with latest results.

@codecov
Copy link

codecov bot commented Sep 21, 2023

Codecov Report

Merging #2254 (5a2ff7f) into develop (07c5a7d) will increase coverage by 0.00%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             develop    #2254   +/-   ##
==========================================
  Coverage      40.37%   40.38%           
  Complexity      1007     1007           
==========================================
  Files            318      318           
  Lines          11619    11617    -2     
  Branches        1540     1540           
==========================================
  Hits            4691     4691           
+ Misses          6489     6487    -2     
  Partials         439      439           
Files Changed Coverage Δ
.../calling/ongoing/fullscreen/SelectedParticipant.kt 0.00% <0.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 07c5a7d...5a2ff7f. Read the comment docs.

@github-actions
Copy link
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

@AndroidBob
Copy link
Collaborator

Build 880 succeeded.

The build produced the following APK's:

@ohassine ohassine requested review from a team, typfel, gongracr, yamilmedina, mchenani and trOnk12 and removed request for a team September 21, 2023 10:56
@github-actions
Copy link
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

@AndroidBob
Copy link
Collaborator

Build 901 succeeded.

The build produced the following APK's:

@github-actions
Copy link
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

@ohassine ohassine added this pull request to the merge queue Sep 25, 2023
@AndroidBob
Copy link
Collaborator

Build 940 succeeded.

The build produced the following APK's:

Merged via the queue into develop with commit b333593 Sep 25, 2023
13 of 14 checks passed
@ohassine ohassine deleted the self_video_not_updated_on_full_screen branch September 25, 2023 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
4 participants