Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: revert changes of #2246 #2265

Merged
merged 1 commit into from Sep 25, 2023
Merged

chore: revert changes of #2246 #2265

merged 1 commit into from Sep 25, 2023

Conversation

ohassine
Copy link
Member


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

revert changes of #2246 as it introduced some new bugs


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@github-actions
Copy link
Contributor

Test Results

611 tests  ±0   610 ✔️ ±0   6m 35s ⏱️ + 1m 23s
  88 suites ±0       1 💤 ±0 
  88 files   ±0       0 ±0 

Results for commit 3b7e520. ± Comparison against base commit 07c5a7d.

@github-actions
Copy link
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

@AndroidBob
Copy link
Collaborator

Build 929 succeeded.

The build produced the following APK's:

@ohassine ohassine requested review from a team, typfel, gongracr, MohamadJaara, mchenani and saleniuk and removed request for a team September 25, 2023 11:30
@ohassine ohassine added this pull request to the merge queue Sep 25, 2023
Merged via the queue into develop with commit 3e508a1 Sep 25, 2023
13 checks passed
@ohassine ohassine deleted the revert_changes_develop branch September 25, 2023 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
4 participants