-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: fixed ping translations in German [WPB-4728] #2275
Conversation
Build 1016 failed. |
Codecov Report
@@ Coverage Diff @@
## develop #2275 +/- ##
=============================================
- Coverage 40.50% 40.50% -0.01%
Complexity 1015 1015
=============================================
Files 318 318
Lines 11665 11666 +1
Branches 1551 1552 +1
=============================================
Hits 4725 4725
- Misses 6496 6497 +1
Partials 444 444
Continue to review full report in Codecov by Sentry.
|
APKs built during tests are available here. Scroll down to Artifacts! |
Build 1017 succeeded. The build produced the following APK's: |
APKs built during tests are available here. Scroll down to Artifacts! |
Build 1024 succeeded. The build produced the following APK's: |
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764
The PR Description
What's new in this PR?
Issues
Knock system messages translations were still not discriminating between self and other users triggering the action, hence the German translation was broken (
Sie hat gepingt
vsSie haben gepingt
)Solutions
Added a flag to discern whether self user triggered the action or not.
Testing
Test Coverage (Optional)
How to Test
Attachments (Optional)
PR Post Submission Checklist for internal contributors (Optional)
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764
.