Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fixed ping translations in German [WPB-4728] #2275

Merged
merged 3 commits into from
Sep 27, 2023

Conversation

gongracr
Copy link
Contributor

@gongracr gongracr commented Sep 27, 2023

BugWPB-4728 Applause -[Android] Chat - Poor translated ping message


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

Knock system messages translations were still not discriminating between self and other users triggering the action, hence the German translation was broken (Sie hat gepingt vs Sie haben gepingt)

Solutions

Added a flag to discern whether self user triggered the action or not.

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

  • Change locale to German.
  • Go into a conversation.
  • Send a ping.
  • Receive a ping.
  • Check translations are correct

Attachments (Optional)

Before After
Captura de pantalla 2023-09-27 a las 11 48 37 Captura de pantalla 2023-09-27 a las 11 46 33

PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@gongracr gongracr requested review from a team, yamilmedina, borichellow, vitorhugods, mchenani and ohassine and removed request for a team September 27, 2023 09:49
@github-actions
Copy link
Contributor

github-actions bot commented Sep 27, 2023

Test Results

623 tests  ±0   622 ✔️ ±0   5m 42s ⏱️ - 1m 32s
  89 suites ±0       1 💤 ±0 
  89 files   ±0       0 ±0 

Results for commit 943b0ca. ± Comparison against base commit f65934a.

♻️ This comment has been updated with latest results.

@AndroidBob
Copy link
Collaborator

Build 1016 failed.

@codecov
Copy link

codecov bot commented Sep 27, 2023

Codecov Report

Merging #2275 (943b0ca) into develop (f65934a) will decrease coverage by 0.01%.
Report is 1 commits behind head on develop.
The diff coverage is 66.66%.

@@              Coverage Diff              @@
##             develop    #2275      +/-   ##
=============================================
- Coverage      40.50%   40.50%   -0.01%     
  Complexity      1015     1015              
=============================================
  Files            318      318              
  Lines          11665    11666       +1     
  Branches        1551     1552       +1     
=============================================
  Hits            4725     4725              
- Misses          6496     6497       +1     
  Partials         444      444              
Files Coverage Δ
...e/android/ui/home/conversations/model/UIMessage.kt 57.92% <100.00%> (ø)
...wire/android/mapper/RegularMessageContentMapper.kt 24.46% <0.00%> (-0.18%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f65934a...943b0ca. Read the comment docs.

@github-actions
Copy link
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

@AndroidBob
Copy link
Collaborator

Build 1017 succeeded.

The build produced the following APK's:

@github-actions
Copy link
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

@gongracr gongracr added this pull request to the merge queue Sep 27, 2023
@AndroidBob
Copy link
Collaborator

Build 1024 succeeded.

The build produced the following APK's:

Merged via the queue into develop with commit 4e7a254 Sep 27, 2023
14 checks passed
@gongracr gongracr deleted the fix/broken_german_translations branch September 27, 2023 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
4 participants