Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(debug): add debug option for disabling event processing #2277

Merged

Conversation

typfel
Copy link
Member

@typfel typfel commented Sep 27, 2023


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Add debug option for disabling event processing. Useful when testing recovering from an epoch which has gone out of sync due to missed commits.

I also moved some option "MLS" section to the new "Debug Tool" section since they weren't really related to MLS.

Screenshot 2023-09-27 at 14 38 49

Needs releases with:

Attachments (Optional)

Attachments like images, videos, etc. (drag and drop in the text box)


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 27, 2023

Test Results

623 tests  ±0   622 ✔️ ±0   4m 15s ⏱️ - 4m 21s
  89 suites ±0       1 💤 ±0 
  89 files   ±0       0 ±0 

Results for commit d4c773f. ± Comparison against base commit ced5c34.

♻️ This comment has been updated with latest results.

@codecov
Copy link

codecov bot commented Sep 27, 2023

Codecov Report

Merging #2277 (d4c773f) into feat/migration-system-messages (ced5c34) will decrease coverage by 0.03%.
The diff coverage is 0.00%.

@@                         Coverage Diff                          @@
##             feat/migration-system-messages    #2277      +/-   ##
====================================================================
- Coverage                             40.51%   40.49%   -0.03%     
  Complexity                             1015     1015              
====================================================================
  Files                                   318      318              
  Lines                                 11699    11706       +7     
  Branches                               1554     1554              
====================================================================
  Hits                                   4740     4740              
- Misses                                 6512     6519       +7     
  Partials                                447      447              
Files Coverage Δ
...tlin/com/wire/android/ui/debug/DebugDataOptions.kt 0.00% <0.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ced5c34...d4c773f. Read the comment docs.

@AndroidBob
Copy link
Collaborator

Build 1023 succeeded.

The build produced the following APK's:

@github-actions
Copy link
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

@typfel typfel merged commit ac95e17 into feat/migration-system-messages Sep 27, 2023
17 checks passed
@typfel typfel deleted the feat/disable-event-processing branch September 27, 2023 19:36
@typfel typfel mentioned this pull request Oct 15, 2023
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
4 participants