Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: [RC] feature flag passowrd guest link (WPB-1531) #2282

Merged

Conversation

alexandreferris
Copy link
Contributor


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Manual cherry-pick of #2133

Issues

  1. add feature flag to prevent password link creation
  2. fix: join dialog is not cancelable
  3. fix: change shield icon tint to match the text color
screen-20230824-102736.mp4

Needs releases with:

  • GitHub link to other pull request

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.

Notes (Optional)

Specify here any other facts that you think are important for this issue.

Attachments (Optional)

Attachments like images, videos, etc. (drag and drop in the text box)


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

Copy link
Contributor

@yamilmedina yamilmedina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewd and to my eyes I see everything ported to have the feature disabled 👏

@github-actions
Copy link
Contributor

github-actions bot commented Sep 28, 2023

Test Results

593 tests   592 ✔️  7m 24s ⏱️
  85 suites      1 💤
  85 files        0

Results for commit e3105fc.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

@yamilmedina yamilmedina requested review from a team, typfel, borichellow, mchenani, Garzas and saleniuk and removed request for a team September 28, 2023 09:48
@github-actions
Copy link
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

@AndroidBob
Copy link
Collaborator

Build 1044 succeeded.

The build produced the following APK's:

@yamilmedina yamilmedina merged commit 7561598 into release/candidate Sep 28, 2023
13 checks passed
@yamilmedina yamilmedina deleted the feat/feature-flag-passowrd-guest-link-rc branch September 28, 2023 11:47
@alexandreferris alexandreferris removed WIP Work In Progress DO NOT MERGE labels Sep 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
4 participants