feat: archived conversation list [WPB-4429] #2295

Garzas · 2023-10-02T14:20:32Z

WPB-4429 [UI] Create archived conversation tab and archived conversation list

PR Submission Checklist for internal contributors

The PR Title
- conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
- contains a reference JIRA issue number like SQPIT-764
- answers the question: If merged, this PR will: ... ³
The PR Description
- is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

archived conversation list
archived conversation list search
added test for conversation list view model

search.mp4

list.mp4

codecov · 2023-10-02T14:57:16Z

Codecov Report

Merging #2295 (d36b95a) into develop (b2e2292) will increase coverage by 0.64%.
The diff coverage is 56.36%.

@@              Coverage Diff              @@
##             develop    #2295      +/-   ##
=============================================
+ Coverage      40.72%   41.36%   +0.64%     
- Complexity      1034     1046      +12     
=============================================
  Files            323      324       +1     
  Lines          11748    11731      -17     
  Branches        1564     1554      -10     
=============================================
+ Hits            4784     4853      +69     
+ Misses          6510     6410     -100     
- Partials         454      468      +14

Files	Coverage Δ
...id/ui/home/conversationslist/ConversationRouter.kt	`0.00% <ø> (ø)`
...oid/ui/home/conversationslist/model/SearchQuery.kt	`100.00% <100.00%> (ø)`
...id/ui/sharing/ImportMediaAuthenticatedViewModel.kt	`0.00% <0.00%> (ø)`
...ome/conversationslist/ConversationListViewModel.kt	`57.46% <53.06%> (+17.13%)`	⬆️

... and 4 files with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b2e2292...d36b95a. Read the comment docs.

github-actions · 2023-10-02T15:09:00Z

Test Results

629 tests +3 629 ✔️ +3 10m 43s ⏱️ + 4m 25s
  92 suites ±0     0 💤 ±0
  92 files ±0     0 ❌ ±0

Results for commit d36b95a. ± Comparison against base commit b2e2292.

♻️ This comment has been updated with latest results.

github-actions · 2023-10-02T15:09:02Z

APKs built during tests are available here. Scroll down to Artifacts!

AndroidBob · 2023-10-02T15:25:11Z

Build 1106 succeeded.

The build produced the following APK's:

com.wire.android-v4.5.0(7729090)(7729090)-staging-compat.apk

AndroidBob · 2023-10-03T06:38:47Z

Build 1124 failed.

borichellow · 2023-10-03T09:56:50Z

app/src/main/kotlin/com/wire/android/WireApplication.kt

@@ -112,7 +112,7 @@ class WireApplication : Application(), Configuration.Provider {
                    .detectDiskReads()
                    .detectDiskWrites()
                    .penaltyLog()
-                    .penaltyDeath()
+//                    .penaltyDeath()


shouldn't be reverted?

borichellow · 2023-10-03T10:06:50Z

app/src/main/kotlin/com/wire/android/ui/home/conversationslist/model/SearchQuery.kt

+ */
+package com.wire.android.ui.home.conversationslist.model
+
+data class SearchQuery(val text: String, val fromArchive: Boolean)


I don't like this boolean. For now it's enough, but later the app could also have "folders" and "contacts" later. So IMO enum class would be preferable here.

I think that Boris has a point. Also implementation with let's say sourceType sealed type shouldn't be much more difficult as now we only have Archive and "normal" conversations.

I added comment about it but I can implement it right now 😄

borichellow · 2023-10-03T10:09:50Z

app/src/main/kotlin/com/wire/android/ui/home/conversationslist/ConversationListViewModel.kt

+                is SearchQueryUpdate.UpdateConversationsSource -> currentSearchQuery.copy(
+                    text = "",
+                    fromArchive = update.fromArchive
+                )


is SearchQueryUpdate.UpdateConversationsSource -> { if (currentSearchQuery.fromArchive != update.fromArchive) currentSearchQuery.copy( text = "", fromArchive = update.fromArchive ) else currentSearchQuery }

gongracr

Looking good in general. Just a small comment regarding code simplification on the Search query mechanism. Feel free to ignore if the final implementation turns to be much more complex and would compromise the release of the feature.

AndroidBob · 2023-10-04T10:01:59Z

Build 1137 failed.

gongracr

Much better now 🦾 Thanks for changes!

borichellow

great job, thanks :)

AndroidBob · 2023-10-04T11:56:30Z

Build 1139 failed.

github-actions · 2023-10-04T13:16:36Z

APKs built during tests are available here. Scroll down to Artifacts!

AndroidBob · 2023-10-04T13:27:50Z

Build 1144 succeeded.

The build produced the following APK's:

com.wire.android-v4.5.0(7745697)(7745697)-staging-compat.apk

Garzas added 4 commits September 29, 2023 15:30

feat: archived conversations

ee3bc72

kalium update

c0258a7

Merge branch 'develop' into feat/archived-conversation-list

608b3ac

added tests

41f23e2

Garzas requested review from gongracr, yamilmedina, alexandreferris and a team October 2, 2023 14:20

Garzas self-assigned this Oct 2, 2023

Garzas requested review from typfel and borichellow and removed request for a team October 2, 2023 14:20

pull-request-size bot added the size/L label Oct 2, 2023

kalium update

fa15b0d

added documentation

a3227c0

borichellow reviewed Oct 3, 2023

View reviewed changes

gongracr reviewed Oct 3, 2023

View reviewed changes

Garzas added 2 commits October 4, 2023 11:43

review fixes

31addc0

test fixes

0f9df00

Garzas requested review from gongracr and borichellow October 4, 2023 09:50

gongracr approved these changes Oct 4, 2023

View reviewed changes

borichellow approved these changes Oct 4, 2023

View reviewed changes

alexandreferris approved these changes Oct 4, 2023

View reviewed changes

kalium update

3c0f3c4

Garzas added 2 commits October 4, 2023 14:35

Merge branch 'develop' into feat/archived-conversation-list

053c769

detekt fix

d36b95a

Garzas enabled auto-merge October 4, 2023 12:50

Garzas added this pull request to the merge queue Oct 4, 2023

Merged via the queue into develop with commit 7340e57 Oct 4, 2023
14 of 15 checks passed

Garzas deleted the feat/archived-conversation-list branch October 4, 2023 13:26

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: archived conversation list [WPB-4429] #2295

feat: archived conversation list [WPB-4429] #2295

Garzas commented Oct 2, 2023 •

edited by github-actions bot

codecov bot commented Oct 2, 2023 •

edited

github-actions bot commented Oct 2, 2023 •

edited

github-actions bot commented Oct 2, 2023

AndroidBob commented Oct 2, 2023

AndroidBob commented Oct 3, 2023

borichellow Oct 3, 2023

borichellow Oct 3, 2023

gongracr Oct 3, 2023

Garzas Oct 4, 2023

borichellow Oct 3, 2023

gongracr left a comment

AndroidBob commented Oct 4, 2023

gongracr left a comment

borichellow left a comment

AndroidBob commented Oct 4, 2023

github-actions bot commented Oct 4, 2023

AndroidBob commented Oct 4, 2023

feat: archived conversation list [WPB-4429] #2295

feat: archived conversation list [WPB-4429] #2295

Conversation

Garzas commented Oct 2, 2023 • edited by github-actions bot

PR Submission Checklist for internal contributors

What's new in this PR?

codecov bot commented Oct 2, 2023 • edited

Codecov Report

github-actions bot commented Oct 2, 2023 • edited

Test Results

github-actions bot commented Oct 2, 2023

AndroidBob commented Oct 2, 2023

AndroidBob commented Oct 3, 2023

borichellow Oct 3, 2023

Choose a reason for hiding this comment

borichellow Oct 3, 2023

Choose a reason for hiding this comment

gongracr Oct 3, 2023

Choose a reason for hiding this comment

Garzas Oct 4, 2023

Choose a reason for hiding this comment

borichellow Oct 3, 2023

Choose a reason for hiding this comment

gongracr left a comment

Choose a reason for hiding this comment

AndroidBob commented Oct 4, 2023

gongracr left a comment

Choose a reason for hiding this comment

borichellow left a comment

Choose a reason for hiding this comment

AndroidBob commented Oct 4, 2023

github-actions bot commented Oct 4, 2023

AndroidBob commented Oct 4, 2023

Garzas commented Oct 2, 2023 •

edited by github-actions bot

codecov bot commented Oct 2, 2023 •

edited

github-actions bot commented Oct 2, 2023 •

edited