Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add confirmation dialog archiving [WPB-4434] #2300

Merged
merged 5 commits into from Oct 5, 2023

Conversation

gongracr
Copy link
Contributor

@gongracr gongracr commented Oct 4, 2023

StoryWPB-4434 Add a dialog to confirm archiving a conversation


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

Before archiving a conversation, since it is a semi-critical action, we need to confirm that the user didn't tap on the archiving option by mistake by showing a confirmation dialog.

How to Test

Try to archive a conversation by long tapping a conversation item in the home screen or by navigating to the group or other users details screen and clicking on the options icon (three dots)

Attachments (Optional)

Grabacion.de.pantalla.2023-10-04.a.las.16.36.36.mov

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

…to feat/add_confirmation_dialog_archiving

# Conflicts:
#	app/src/test/kotlin/com/wire/android/ui/home/conversationslist/ConversationListViewModelTest.kt
@github-actions
Copy link
Contributor

github-actions bot commented Oct 4, 2023

Test Results

629 tests  ±0   629 ✔️ ±0   7m 25s ⏱️ - 2m 20s
  92 suites ±0       0 💤 ±0 
  92 files   ±0       0 ±0 

Results for commit 87055a0. ± Comparison against base commit 3522b4a.

This pull request removes 1 and adds 1 tests. Note that renamed tests count towards both.
com.wire.android.ui.home.conversationslist.ConversationListViewModelTest ‑ given a valid conversation state, when archiving it with an error, then the right failure message is shown()
com.wire.android.ui.home.conversationslist.ConversationListViewModelTest ‑ given a valid conversation state, when un-archiving it with an error, then the right failure message is shown()

♻️ This comment has been updated with latest results.

@AndroidBob
Copy link
Collaborator

Build 1150 failed.

@codecov
Copy link

codecov bot commented Oct 4, 2023

Codecov Report

Merging #2300 (87055a0) into develop (3522b4a) will increase coverage by 0.05%.
The diff coverage is 60.00%.

@@              Coverage Diff              @@
##             develop    #2300      +/-   ##
=============================================
+ Coverage      41.36%   41.42%   +0.05%     
  Complexity      1046     1046              
=============================================
  Files            324      324              
  Lines          11731    11731              
  Branches        1554     1560       +6     
=============================================
+ Hits            4853     4859       +6     
+ Misses          6410     6403       -7     
- Partials         468      469       +1     
Files Coverage Δ
...tions/details/GroupConversationDetailsViewModel.kt 59.59% <100.00%> (+0.50%) ⬆️
...roupConversationDetailsBottomSheetEventsHandler.kt 0.00% <ø> (ø)
...id/ui/home/conversationslist/ConversationRouter.kt 0.00% <0.00%> (ø)
...ome/conversationslist/ConversationListViewModel.kt 57.72% <58.82%> (+0.26%) ⬆️

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3522b4a...87055a0. Read the comment docs.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 4, 2023

APKs built during tests are available here. Scroll down to Artifacts!

@AndroidBob
Copy link
Collaborator

Build 1154 succeeded.

The build produced the following APK's:

@gongracr gongracr added this pull request to the merge queue Oct 5, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 5, 2023
@gongracr gongracr added this pull request to the merge queue Oct 5, 2023
Merged via the queue into develop with commit 013245e Oct 5, 2023
14 checks passed
@gongracr gongracr deleted the feat/add_confirmation_dialog_archiving branch October 5, 2023 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
4 participants