fix: use stable compose bom version to fix video calls [WPB-4992] #2326
Conversation
Garzas
requested review from
alexandreferris,
vitorhugods,
ohassine and
saleniuk
|
Build 1297 failed. |
|
Build 1302 failed. |
|
APKs built during tests are available here. Scroll down to Artifacts! |
gradle/libs.versions.toml
Outdated
| compose-compiler = "1.5.2" | ||
| compose-constraint = "1.0.1" | ||
| compose-material3 = "1.2.0-alpha09" | ||
| compose-navigation = "2.6.0" | ||
| compose-navigation = "2.7.4" |
There was a problem hiding this comment.
question: is it necessary? have you checked if it works well with "compose destinations" and we don't need to update it as well? 😄
| @@ -51,7 +43,8 @@ import kotlin.math.roundToInt | |||
| * @see SnackbarData | |||
| * @see SnackbarHostState | |||
| */ | |||
| @OptIn(ExperimentalFoundationApi::class) | |||
|
|
|||
| // TODO uncomment all lines when anchoredDraggable will be available on new compose version | |||
There was a problem hiding this comment.
suggestion: add the info about which particular version we would need to have to make it work again, maybe also mark that in the comment in libs.versions.toml next to the current version number, so that if someone updates it, will see that it can be now uncommented
I would also mark each one of the comments that are related to this, because with time we can have more things commented, or remove commented code completely and just add reference to this PR in comment so that it would be still easy to put back 😄
|
Build 1320 succeeded. The build produced the following APK's: |
|
Build 1334 failed. |
…oaded into fix/compose-bom
|
Build 1335 failed. |
|
APKs built during tests are available here. Scroll down to Artifacts! |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
|
Build 1336 succeeded. The build produced the following APK's: |
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764The PR Description
What's new in this PR?
Issues
Solutions
Dependencies (Optional)
If there are some other pull requests related to this one (e.g. new releases of frameworks), specify them here.
Needs releases with:
Testing
Test Coverage (Optional)
How to Test
Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.
Notes (Optional)
Specify here any other facts that you think are important for this issue.
Attachments (Optional)
Attachments like images, videos, etc. (drag and drop in the text box)
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.