Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Show e2ei certificate in device details screen - PART 2 (WPB-3214) #2332

Merged
merged 4 commits into from Oct 25, 2023

Conversation

ohassine
Copy link
Member

@ohassine ohassine commented Oct 16, 2023

StoryWPB-3214 [Android] 5.3.24 Show E2EI certificate info


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Description

In this PR, I created certificate screen details which allow the user to copy or download it

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

Needs #2316 to be able to test

Attachments (Optional)

Wire 2023-10-16 at 4_58 PM


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 16, 2023

Test Results

652 tests  ±0   652 ✔️ ±0   10m 20s ⏱️ + 1m 48s
  96 suites ±0       0 💤 ±0 
  96 files   ±0       0 ±0 

Results for commit c69061e. ± Comparison against base commit 1385f09.

♻️ This comment has been updated with latest results.

@AndroidBob
Copy link
Collaborator

Build 1341 failed.

@codecov
Copy link

codecov bot commented Oct 16, 2023

Codecov Report

Merging #2332 (c69061e) into develop (1385f09) will decrease coverage by 0.03%.
The diff coverage is 0.00%.

@@              Coverage Diff              @@
##             develop    #2332      +/-   ##
=============================================
- Coverage      41.39%   41.36%   -0.03%     
  Complexity      1068     1068              
=============================================
  Files            340      341       +1     
  Lines          12150    12158       +8     
  Branches        1598     1598              
=============================================
  Hits            5029     5029              
- Misses          6644     6652       +8     
  Partials         477      477              
Files Coverage Δ
.../src/main/kotlin/com/wire/android/util/FileUtil.kt 0.00% <ø> (ø)
...gs/devices/e2ei/E2eiCertificateDetailsViewModel.kt 0.00% <0.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1385f09...c69061e. Read the comment docs.

@github-actions
Copy link
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

@AndroidBob
Copy link
Collaborator

Build 1345 succeeded.

The build produced the following APK's:

@ohassine ohassine added this pull request to the merge queue Oct 25, 2023
@github-actions
Copy link
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

Merged via the queue into develop with commit a089fdf Oct 25, 2023
13 of 14 checks passed
@ohassine ohassine deleted the certificate_details_screen branch October 25, 2023 12:35
@AndroidBob
Copy link
Collaborator

Build 1520 succeeded.

The build produced the following APK's:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
4 participants