New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Show conversation Proteus verification status #2350
feat: Show conversation Proteus verification status #2350
Conversation
Build 1435 failed. |
Build 1439 failed. |
Codecov Report
@@ Coverage Diff @@
## develop #2350 +/- ##
=============================================
+ Coverage 41.44% 41.47% +0.02%
Complexity 1072 1072
=============================================
Files 341 341
Lines 12186 12204 +18
Branches 1602 1603 +1
=============================================
+ Hits 5050 5061 +11
- Misses 6656 6663 +7
Partials 480 480
Continue to review full report in Codecov by Sentry.
|
APKs built during tests are available here. Scroll down to Artifacts! |
Build 1440 succeeded. The build produced the following APK's: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
APKs built during tests are available here. Scroll down to Artifacts! |
Build 1470 succeeded. The build produced the following APK's: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work! Just waiting on the resolving of the merging conflict 😄
…github.com:wireapp/wire-android-reloaded into feat/show_conversation_proteus_verification_status
APKs built during tests are available here. Scroll down to Artifacts! |
Build 1542 succeeded. The build produced the following APK's: |
APKs built during tests are available here. Scroll down to Artifacts! |
Build 1555 succeeded. The build produced the following APK's: |
What's new in this PR?
Issues
When the conversation is "Proteus verified" user should know about it: corresponding icon next to the conversation name and systemMessage in a conversation + systemMessage when the conversation becomes Degraded (was verified in past but not anymore).
Needs releases with:
How to Test
expected result:
there should be a system message informing that conversation is Verified now + blue shield icon is next to the user name
expected:
blue shield icon is next to the user name and second line in conversation item is SystemMessage
expected result:
there should be a system message informing that conversation is Verified now + blue is next to the conversation name
expected:
blue shield icon is next to the conversation name and second line in conversation item is SystemMessage
expected result:
there should be a system message informing that conversation is NOT Verified anymore + NO blue is next to the conversation name
expected:
NO blue shield is next to the conversation name and second line in conversation item is SystemMessage
Attachments (Optional)