Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Show conversation Proteus verification status #2350

Merged

Conversation

borichellow
Copy link
Contributor

@borichellow borichellow commented Oct 19, 2023

What's new in this PR?

Issues

When the conversation is "Proteus verified" user should know about it: corresponding icon next to the conversation name and systemMessage in a conversation + systemMessage when the conversation becomes Degraded (was verified in past but not anymore).

Needs releases with:

How to Test

  • open some users profile
  • go to Devices tab
  • verify all the devices of the user
  • go to the conversation with that user
    expected result:
    there should be a system message informing that conversation is Verified now + blue shield icon is next to the user name
  • go to the Conversations List screen
    expected:
    blue shield icon is next to the user name and second line in conversation item is SystemMessage
  • open some group conversation
  • verify all the devices of all the users in that group (see the prev. test)
  • go to that conversation
    expected result:
    there should be a system message informing that conversation is Verified now + blue is next to the conversation name
  • go to the Conversations List screen
    expected:
    blue shield icon is next to the conversation name and second line in conversation item is SystemMessage
  • do all from test-2
  • un-verify at least 1 device of 1 user
  • go to that conversation
    expected result:
    there should be a system message informing that conversation is NOT Verified anymore + NO blue is next to the conversation name
  • go to the Conversations List screen
    expected:
    NO blue shield is next to the conversation name and second line in conversation item is SystemMessage

Attachments (Optional)

Screenshot 2023-10-27 at 11 40 09 Screenshot 2023-10-27 at 11 40 21 Screenshot 2023-10-19 at 17 59 17 Screenshot 2023-10-19 at 17 59 53 Screenshot 2023-10-19 at 17 59 35

@CLAassistant
Copy link

CLAassistant commented Oct 19, 2023

CLA assistant check
All committers have signed the CLA.

@borichellow borichellow requested review from saleniuk and removed request for gongracr October 19, 2023 15:14
@borichellow borichellow requested review from gongracr, Garzas, saleniuk and mchenani and removed request for saleniuk October 19, 2023 15:14
@github-actions
Copy link
Contributor

github-actions bot commented Oct 19, 2023

Test Results

655 tests  ±0   655 ✔️ ±0   7m 14s ⏱️ - 2m 11s
  96 suites ±0       0 💤 ±0 
  96 files   ±0       0 ±0 

Results for commit d57fbc3. ± Comparison against base commit a60a8f8.

♻️ This comment has been updated with latest results.

@AndroidBob
Copy link
Collaborator

Build 1435 failed.

@AndroidBob
Copy link
Collaborator

Build 1439 failed.

@codecov
Copy link

codecov bot commented Oct 20, 2023

Codecov Report

Merging #2350 (d57fbc3) into develop (a60a8f8) will increase coverage by 0.02%.
The diff coverage is 57.69%.

@@              Coverage Diff              @@
##             develop    #2350      +/-   ##
=============================================
+ Coverage      41.44%   41.47%   +0.02%     
  Complexity      1072     1072              
=============================================
  Files            341      341              
  Lines          12186    12204      +18     
  Branches        1602     1603       +1     
=============================================
+ Hits            5050     5061      +11     
- Misses          6656     6663       +7     
  Partials         480      480              
Files Coverage Δ
...tions/details/GroupConversationDetailsViewModel.kt 60.67% <100.00%> (+0.58%) ⬆️
...me/conversations/info/ConversationInfoViewModel.kt 79.72% <100.00%> (+0.27%) ⬆️
...me/conversations/info/ConversationInfoViewState.kt 100.00% <100.00%> (ø)
...ome/conversationslist/ConversationListViewModel.kt 58.03% <ø> (ø)
...i/home/conversationslist/model/ConversationItem.kt 96.29% <100.00%> (+0.46%) ⬆️
...tlin/com/wire/android/migration/MigrationMapper.kt 0.00% <0.00%> (ø)
...e/android/ui/home/conversations/model/UIMessage.kt 54.79% <0.00%> (-0.34%) ⬇️
...id/ui/sharing/ImportMediaAuthenticatedViewModel.kt 0.00% <0.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a60a8f8...d57fbc3. Read the comment docs.

@github-actions
Copy link
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

@AndroidBob
Copy link
Collaborator

Build 1440 succeeded.

The build produced the following APK's:

Copy link
Member

@mchenani mchenani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

@AndroidBob
Copy link
Collaborator

Build 1470 succeeded.

The build produced the following APK's:

Copy link
Contributor

@alexandreferris alexandreferris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! Just waiting on the resolving of the merging conflict 😄

@github-actions
Copy link
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

@AndroidBob
Copy link
Collaborator

Build 1542 succeeded.

The build produced the following APK's:

@github-actions
Copy link
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

@borichellow borichellow added this pull request to the merge queue Oct 27, 2023
@AndroidBob
Copy link
Collaborator

Build 1555 succeeded.

The build produced the following APK's:

Merged via the queue into develop with commit 3c608e9 Oct 27, 2023
13 of 15 checks passed
@borichellow borichellow deleted the feat/show_conversation_proteus_verification_status branch October 27, 2023 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants