Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: expanded message composer edit state #2360

Merged
merged 16 commits into from
Oct 23, 2023
Merged

fix: expanded message composer edit state #2360

merged 16 commits into from
Oct 23, 2023

Conversation

Garzas
Copy link
Contributor

@Garzas Garzas commented Oct 23, 2023

PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³

  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Fixed not visible action buttons when editing texts on expand mode

yamilmedina and others added 14 commits October 17, 2023 15:58
@pull-request-size pull-request-size bot added size/M and removed size/L labels Oct 23, 2023
@Garzas Garzas enabled auto-merge October 23, 2023 09:41
@github-actions
Copy link
Contributor

github-actions bot commented Oct 23, 2023 •
edited

Test Results

649 tests  ±0   649 ✔️ ±0   7m 10s ⏱️ -34s
  94 suites ±0       0 💤 ±0 
  94 files   ±0       0 ❌ ±0 

Results for commit 7b61c6b. ± Comparison against base commit f33e2f8.

♻️ This comment has been updated with latest results.

@Garzas Garzas added this pull request to the merge queue Oct 23, 2023
@github-actions
Copy link
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

@AndroidBob
Copy link
Collaborator

Build 1466 succeeded.

The build produced the following APK's:

Merged via the queue into develop with commit e3e8790 Oct 23, 2023
13 of 14 checks passed
@Garzas Garzas deleted the fix/expanded-message-composer-edit-state branch October 23, 2023 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yamilmedina yamilmedina yamilmedina approved these changes

@alexandreferris alexandreferris alexandreferris approved these changes

Assignees

@Garzas Garzas

Labels
size/M
Projects
None yet
Milestone
No milestone
4 participants
@Garzas @AndroidBob @yamilmedina @alexandreferris