Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update applock copy (WPB-5093) #2364

Merged
merged 2 commits into from
Oct 24, 2023
Merged

fix: update applock copy (WPB-5093) #2364

merged 2 commits into from
Oct 24, 2023

Conversation

ohassine
Copy link
Member

@ohassine ohassine commented Oct 23, 2023

TaskWPB-5093 [Android] Adjust the text to include “Unlock with biometric data or enter your password”.


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Description

Adjust the text to include “Unlock with biometric data or enter your password”.

Needs releases with:

  • GitHub link to other pull request

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@ohassine ohassine requested review from a team, gongracr, yamilmedina, alexandreferris, MohamadJaara and Garzas and removed request for a team October 23, 2023 15:13
@github-actions
Copy link
Contributor

github-actions bot commented Oct 23, 2023

Test Results

652 tests  ±0   652 ✔️ ±0   7m 20s ⏱️ +51s
  96 suites ±0       0 💤 ±0 
  96 files   ±0       0 ±0 

Results for commit eb8fa6f. ± Comparison against base commit 5d51253.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

@AndroidBob
Copy link
Collaborator

Build 1488 succeeded.

The build produced the following APK's:

@github-actions
Copy link
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

@AndroidBob
Copy link
Collaborator

Build 1490 succeeded.

The build produced the following APK's:

@ohassine ohassine added this pull request to the merge queue Oct 24, 2023
Merged via the queue into develop with commit 6b22ade Oct 24, 2023
14 checks passed
@ohassine ohassine deleted the update_applock_copy branch October 24, 2023 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
4 participants