Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: optimise build cache #2373

Merged
merged 2 commits into from Oct 30, 2023
Merged

Conversation

vitorhugods
Copy link
Contributor

@vitorhugods vitorhugods commented Oct 25, 2023


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

We're not taking full advantage of Buildjet machines by using standard setup and cache actions.

Solutions

As seen in this guide by Buildjet, we can use their actions to optimise things.

Also, make sure we only use one gradle cache in each build, instead of two (setup-java + gradle-build-action).


PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@vitorhugods vitorhugods marked this pull request as ready for review October 25, 2023 12:37
@github-actions
Copy link
Contributor

Test Results

594 tests   593 ✔️  7m 0s ⏱️
  85 suites      1 💤
  85 files        0

Results for commit da15a07.

@github-actions
Copy link
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

@vitorhugods vitorhugods enabled auto-merge (squash) October 25, 2023 12:38
Copy link
Member

@ohassine ohassine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kalium is waiting 🕺🪩

@AndroidBob
Copy link
Collaborator

Build 1524 succeeded.

The build produced the following APK's:

@vitorhugods vitorhugods requested review from a team, typfel, gongracr, MohamadJaara, Garzas and saleniuk and removed request for a team October 26, 2023 12:45
@vitorhugods vitorhugods merged commit 15ead93 into release/candidate Oct 30, 2023
8 of 9 checks passed
@vitorhugods vitorhugods deleted the ci/optimise-build-cache branch October 30, 2023 12:12
@github-actions
Copy link
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

@AndroidBob
Copy link
Collaborator

Build 1585 succeeded.

The build produced the following APK's:

vitorhugods added a commit that referenced this pull request Oct 30, 2023
Make sure we only use one gradle cache in each build, instead of two (setup-java + gradle-build-action).
Also, prefer Buildjet actions instead of default ones when available.

(cherry picked from commit 15ead93)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
4 participants