New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: optimise build cache #2373
Merged
Merged
ci: optimise build cache #2373
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
APKs built during tests are available here. Scroll down to Artifacts! |
ohassine
approved these changes
Oct 25, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Kalium is waiting 🕺🪩
Build 1524 succeeded. The build produced the following APK's: |
vitorhugods
requested review from
a team,
typfel,
gongracr,
MohamadJaara,
Garzas and
saleniuk
and removed request for
a team
October 26, 2023 12:45
alexandreferris
approved these changes
Oct 30, 2023
APKs built during tests are available here. Scroll down to Artifacts! |
Build 1585 succeeded. The build produced the following APK's: |
vitorhugods
added a commit
that referenced
this pull request
Oct 30, 2023
Make sure we only use one gradle cache in each build, instead of two (setup-java + gradle-build-action). Also, prefer Buildjet actions instead of default ones when available. (cherry picked from commit 15ead93)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Submission Checklist for internal contributors
The PR Title
The PR Description
What's new in this PR?
Issues
We're not taking full advantage of Buildjet machines by using standard setup and cache actions.
Solutions
As seen in this guide by Buildjet, we can use their actions to optimise things.
Also, make sure we only use one gradle cache in each build, instead of two (setup-java + gradle-build-action).
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764
.