fix: navigating with UPDATE_EXISTED, extracting base route [WPB-5225] #2374
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764
The PR Description
What's new in this PR?
Issues
The current code which has been used for months and has been moved around from place to place is faulty in cases when the path contains both path segments and parameters (path elements divided by slashes and arguments after the question mark) like
path/segment?argument=value
. Compose destinations generates non-nullable required navigation argument parameters as segments, and optional parameters as arguments.Function to retrieve the base part of route first checks for the question mark and if it's found, it returns substring up to the question mark, which means when there's a question mark, it ignores slashes and returns
path/segment
instead ofpath
.Solutions
Change this function to find first occurrence of any of these characters (
/
,?
) and substring up to this first found element.Testing
Test Coverage (Optional)
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764
.