Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove app lock after logout #2378

Merged
merged 2 commits into from
Oct 30, 2023
Merged

Conversation

ohassine
Copy link
Member


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

After logout, the app is still requesting passcode

Causes (Optional)

Not handled

Solutions

On logout clear app lock if there is no other account to switch to


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@ohassine ohassine requested review from a team, gongracr, yamilmedina, alexandreferris, borichellow and mchenani and removed request for a team October 26, 2023 12:37
@github-actions
Copy link
Contributor

github-actions bot commented Oct 26, 2023

Test Results

655 tests  ±0   655 ✔️ ±0   8m 13s ⏱️ - 1m 12s
  96 suites ±0       0 💤 ±0 
  96 files   ±0       0 ±0 

Results for commit 5c0e9be. ± Comparison against base commit a60a8f8.

♻️ This comment has been updated with latest results.

@codecov
Copy link

codecov bot commented Oct 26, 2023

Codecov Report

Merging #2378 (5c0e9be) into develop (a60a8f8) will decrease coverage by 0.02%.
The diff coverage is 0.00%.

@@              Coverage Diff              @@
##             develop    #2378      +/-   ##
=============================================
- Coverage      41.44%   41.43%   -0.02%     
  Complexity      1072     1072              
=============================================
  Files            341      341              
  Lines          12186    12189       +3     
  Branches        1602     1603       +1     
=============================================
  Hits            5050     5050              
- Misses          6656     6659       +3     
  Partials         480      480              
Files Coverage Δ
...id/ui/userprofile/self/SelfUserProfileViewModel.kt 0.00% <0.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a60a8f8...5c0e9be. Read the comment docs.

@github-actions
Copy link
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

@AndroidBob
Copy link
Collaborator

Build 1551 succeeded.

The build produced the following APK's:

@ohassine ohassine added this pull request to the merge queue Oct 30, 2023
Merged via the queue into develop with commit 0b2fed5 Oct 30, 2023
14 checks passed
@ohassine ohassine deleted the remove_passcode_after_logout branch October 30, 2023 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
4 participants