Feature : Show conversation history - part 3 - display message's time #238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tion_history_part3
…tion_history_part3
…tion_history_part3 # Conflicts: # app/src/main/kotlin/com/wire/android/feature/conversation/content/ui/ConversationFragment.kt
vitorhugods
requested changes
Jul 27, 2021
app/src/main/kotlin/com/wire/android/core/extension/OffsetDateTime.kt
Outdated
Show resolved
Hide resolved
app/src/main/kotlin/com/wire/android/core/extension/OffsetDateTime.kt
Outdated
Show resolved
Hide resolved
app/src/main/kotlin/com/wire/android/core/extension/OffsetDateTime.kt
Outdated
Show resolved
Hide resolved
...kotlin/com/wire/android/feature/conversation/content/ui/ConversationTextMessageViewHolder.kt
Show resolved
Hide resolved
...kotlin/com/wire/android/feature/conversation/content/ui/ConversationTextMessageViewHolder.kt
Outdated
Show resolved
Hide resolved
...kotlin/com/wire/android/feature/conversation/content/ui/ConversationTextMessageViewHolder.kt
Outdated
Show resolved
Hide resolved
...kotlin/com/wire/android/feature/conversation/content/ui/ConversationTextMessageViewHolder.kt
Outdated
Show resolved
Hide resolved
vitorhugods
approved these changes
Jul 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's new in this PR?
This PR is a follow up of #235.
In this PR we handle displaying message's time with the corresponding separator.
It aims also to display a message's time when the user taps on that one.
Time separators
We have two types of time separators :
When should we display each type of time separators ?
Separator's content
The content time of each type of separators is following the same logic as described below:
JUST NOWwhen the message is received in the last 2 minutes from nowx AGOwhen the message is received in the last 60 minutes from nowEEE, MMM d, HH:mm) when the message is received in the current yearEEE, MMM d, yyyy, HH:mm) for old messages that are not send a year ago or moreScreenshoots