Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: message padding [WPB-5059] #2384

Merged
merged 2 commits into from
Nov 1, 2023
Merged

fix: message padding [WPB-5059] #2384

merged 2 commits into from
Nov 1, 2023

Conversation

Garzas
Copy link
Contributor

@Garzas Garzas commented Oct 31, 2023

BugWPB-5059 [Android] Paddings between messages from the same sender are off


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

  • fixed paddings and added some comments to help understand why we are calculating some paddings for message items

@github-actions
Copy link
Contributor

github-actions bot commented Oct 31, 2023

Test Results

659 tests   659 ✔️  7m 37s ⏱️
  96 suites      0 💤
  96 files        0

Results for commit 07abb56.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

@AndroidBob
Copy link
Collaborator

Build 1594 succeeded.

The build produced the following APK's:

@ohassine ohassine added this pull request to the merge queue Nov 1, 2023
Copy link

codecov bot commented Nov 1, 2023

Codecov Report

Merging #2384 (07abb56) into develop (0b2fed5) will increase coverage by 0.00%.
Report is 3 commits behind head on develop.
The diff coverage is 28.57%.

@@            Coverage Diff             @@
##             develop    #2384   +/-   ##
==========================================
  Coverage      41.49%   41.49%           
  Complexity      1072     1072           
==========================================
  Files            340      340           
  Lines          12187    12189    +2     
  Branches        1604     1604           
==========================================
+ Hits            5057     5058    +1     
  Misses          6650     6650           
- Partials         480      481    +1     
Files Coverage Δ
...roid/ui/settings/devices/DeviceDetailsViewModel.kt 65.17% <28.57%> (-0.28%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e6aef5d...07abb56. Read the comment docs.

Copy link
Contributor

github-actions bot commented Nov 1, 2023

APKs built during tests are available here. Scroll down to Artifacts!

Merged via the queue into develop with commit ca803a7 Nov 1, 2023
13 of 14 checks passed
@ohassine ohassine deleted the fix/message-padding branch November 1, 2023 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
5 participants