Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: remove runner os #2385

Merged
merged 1 commit into from Nov 1, 2023
Merged

ci: remove runner os #2385

merged 1 commit into from Nov 1, 2023

Conversation

ohassine
Copy link
Member

@ohassine ohassine commented Nov 1, 2023


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

UI test action is failing

Invalid workflow file: .github/workflows/gradle-run-ui-tests.yml#L39
The workflow is not valid. .github/workflows/gradle-run-ui-tests.yml (Line: 39, Col: 13): Unrecognized named-value: 'runner'. Located at position 1 within expression: runner.os

Causes (Optional)

Wrong provided runner

Solutions

Revert some changes of f94ee95

Dependencies (Optional)

If there are some other pull requests related to this one (e.g. new releases of frameworks), specify them here.

Needs releases with:

  • GitHub link to other pull request

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.

Notes (Optional)

Specify here any other facts that you think are important for this issue.

Attachments (Optional)

Attachments like images, videos, etc. (drag and drop in the text box)


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

Copy link

codecov bot commented Nov 1, 2023

Codecov Report

Merging #2385 (88d68de) into develop (0b2fed5) will increase coverage by 0.00%.
Report is 2 commits behind head on develop.
The diff coverage is 28.57%.

@@            Coverage Diff             @@
##             develop    #2385   +/-   ##
==========================================
  Coverage      41.49%   41.49%           
  Complexity      1072     1072           
==========================================
  Files            340      340           
  Lines          12187    12189    +2     
  Branches        1604     1604           
==========================================
+ Hits            5057     5058    +1     
  Misses          6650     6650           
- Partials         480      481    +1     
Files Coverage Δ
...roid/ui/settings/devices/DeviceDetailsViewModel.kt 65.17% <28.57%> (-0.28%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c340d50...88d68de. Read the comment docs.

Copy link
Contributor

github-actions bot commented Nov 1, 2023

Test Results

659 tests   659 ✔️  7m 7s ⏱️
  96 suites      0 💤
  96 files        0

Results for commit 88d68de.

Copy link
Contributor

github-actions bot commented Nov 1, 2023

APKs built during tests are available here. Scroll down to Artifacts!

@AndroidBob
Copy link
Collaborator

Build 1604 succeeded.

The build produced the following APK's:

@ohassine ohassine merged commit e6aef5d into develop Nov 1, 2023
17 checks passed
@ohassine ohassine deleted the remove_runner_os_ci branch November 1, 2023 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
4 participants