Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: show e2ei certificate item on debug mode only #2415

Merged
merged 5 commits into from Nov 13, 2023

Conversation

ohassine
Copy link
Member


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

E2ei is still under development and not planned to be release in the next release

Solutions

Hide it for release mode

Needs releases with:

  • GitHub link to other pull request

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

Copy link
Contributor

Test Results

680 tests  ±0   680 ✔️ ±0   9m 53s ⏱️ + 4m 17s
  98 suites ±0       0 💤 ±0 
  98 files   ±0       0 ±0 

Results for commit 70af333. ± Comparison against base commit faf8286.

Copy link
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

@AndroidBob
Copy link
Collaborator

Build 1750 succeeded.

The build produced the following APK's:

Copy link

codecov bot commented Nov 10, 2023

Codecov Report

Merging #2415 (70af333) into develop (faf8286) will decrease coverage by 0.02%.
Report is 1 commits behind head on develop.
The diff coverage is 14.28%.

@@              Coverage Diff              @@
##             develop    #2415      +/-   ##
=============================================
- Coverage      41.48%   41.47%   -0.02%     
  Complexity      1085     1085              
=============================================
  Files            344      344              
  Lines          12430    12434       +4     
  Branches        1632     1633       +1     
=============================================
  Hits            5157     5157              
- Misses          6788     6791       +3     
- Partials         485      486       +1     
Files Coverage Δ
...roid/ui/settings/devices/DeviceDetailsViewModel.kt 63.79% <14.28%> (-2.28%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update faf8286...70af333. Read the comment docs.

@ohassine ohassine requested review from a team, alexandreferris, borichellow, MohamadJaara, vitorhugods and Garzas and removed request for a team November 13, 2023 09:04
@ohassine ohassine added this pull request to the merge queue Nov 13, 2023
Merged via the queue into develop with commit 5900c33 Nov 13, 2023
16 checks passed
@ohassine ohassine deleted the show_e2ei_certificate_on_debug_only branch November 13, 2023 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
4 participants