Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: white screen after splash screen (WPB-5439) - cherrypick #2440

Merged
merged 4 commits into from
Nov 21, 2023

Conversation

ohassine
Copy link
Member

@ohassine ohassine commented Nov 20, 2023

BugWPB-5439 White screen after splash screen


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

Cherrypick of #2417

Needs releases with:

  • GitHub link to other pull request

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@ohassine ohassine changed the title fix: white screen after splash screen (WPB-5439) (#2417) - cherrypick fix: white screen after splash screen (WPB-5439) - cherrypick Nov 20, 2023
@ohassine ohassine changed the base branch from develop to release/candidate November 20, 2023 13:08
@ohassine ohassine requested review from a team, borichellow, vitorhugods, mchenani, Garzas and saleniuk and removed request for a team November 20, 2023 13:08
Copy link
Contributor

Test Results

683 tests  ±0   683 ✔️ ±0   9m 28s ⏱️ -56s
  98 suites ±0       0 💤 ±0 
  98 files   ±0       0 ±0 

Results for commit d016450. ± Comparison against base commit f818ed4.

Copy link
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

@AndroidBob
Copy link
Collaborator

Build 1886 succeeded.

The build produced the following APK's:

@ohassine ohassine enabled auto-merge (squash) November 21, 2023 08:07
@ohassine ohassine merged commit 3c5019b into release/candidate Nov 21, 2023
10 of 11 checks passed
@ohassine ohassine deleted the white_screen_rc branch November 21, 2023 15:49
Copy link
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
4 participants