Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: rename project references as android, deprecating scala repo (rc) #2443

Merged
merged 7 commits into from Nov 21, 2023

Conversation

yamilmedina
Copy link
Contributor


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

Renaming references, to explicitly use wire-android instead of the redirection (that works) wire-android-reloaded.
Allowing in the future to be consistent about naming.


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@yamilmedina yamilmedina changed the title chore: rename project as android, deprecating scala repo chore: rename project as android, deprecating scala repo (rc) Nov 20, 2023
@yamilmedina yamilmedina requested review from a team, vitorhugods, mchenani, Garzas, ohassine and saleniuk and removed request for a team November 20, 2023 21:14
@yamilmedina yamilmedina changed the title chore: rename project as android, deprecating scala repo (rc) chore: rename project references as android, deprecating scala repo (rc) Nov 20, 2023
@AndroidBob
Copy link
Collaborator

Build 1893 succeeded.

The build produced the following APK's:

@AndroidBob
Copy link
Collaborator

Build 1897 succeeded.

The build produced the following APK's:

@yamilmedina yamilmedina enabled auto-merge (squash) November 21, 2023 08:03
Copy link
Contributor

Test Results

0 tests   0 ✔️  0s ⏱️
0 suites  0 💤
0 files    0

Results for commit ac60b8d.

@AndroidBob
Copy link
Collaborator

Build 1902 succeeded.

The build produced the following APK's:

@yamilmedina yamilmedina merged commit 44210a0 into release/candidate Nov 21, 2023
10 of 11 checks passed
@yamilmedina yamilmedina deleted the chore/rename-proj-references-rc branch November 21, 2023 14:17
@AndroidBob
Copy link
Collaborator

Build 1907 succeeded.

The build produced the following APK's:

Copy link
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
4 participants