Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Show all participants sticky button (WPB-5602) #2452

Merged

Conversation

alexandreferris
Copy link
Contributor

@alexandreferris alexandreferris commented Nov 22, 2023

BugWPB-5602 [Android] Show all button in the conversation members screen is only visible after a scroll

…per usage of sticky bottom bar


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

After recent changes the button Show all Participants was not sticky to the bottom anymore.

Causes (Optional)

There was a change from Scaffold to CollapsingTopBarScaffold which has a specific parameter for bottomBar.

Solutions

The solution was to revert back to Scaffold due to not trying to have extra logic to handle the bottom button visibility in CollapsingTopBarScaffold (handling changes on tab rows).

Testing

How to Test

  • Open App
  • Open Conversation
  • Open Conversation Details
  • Click on Participants (must have be a group with 5 or more participants in order for the button to show)
  • Show all Participants button should be sticky to the bottom as before.

Attachments (Optional)

conversation details screen participants showing sticky show all participants button at the bottom

@alexandreferris alexandreferris self-assigned this Nov 22, 2023
@alexandreferris alexandreferris requested review from a team, typfel, yamilmedina, borichellow, MohamadJaara and vitorhugods and removed request for a team November 22, 2023 11:08
@MohamadJaara MohamadJaara enabled auto-merge (squash) November 22, 2023 11:13
@MohamadJaara MohamadJaara merged commit 3afc4af into release/candidate Nov 22, 2023
9 of 11 checks passed
@MohamadJaara MohamadJaara deleted the fix/show_all_participants_sticky_button branch November 22, 2023 11:28
Copy link
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

@AndroidBob
Copy link
Collaborator

Build 1935 succeeded.

The build produced the following APK's:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
5 participants