chore(ci): addresses issue about archiving in releases the APK (cycle 4.4) #2473
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yamilmedina
requested review from
typfel,
alexandreferris,
vitorhugods and
Garzas
and removed request for
a team
yamilmedina
commented
Nov 26, 2023
| } | ||
|
|
||
| sh './gradlew jacocoReport' |
There was a problem hiding this comment.
This is not needed at all in Jenkins. Confirmed with QA.
We only run coverage in GH actions.
|
APKs built during tests are available here. Scroll down to Artifacts! |
yamilmedina
commented
Nov 26, 2023
|
|
||
| // building gh api request | ||
| def apiUrl = shellQuote("https://api.github.com/repos/wireapp/wire-android/releases/latest") | ||
| def releaseId = sh(script: "curl -s ${apiUrl} | grep -m 1 \"id.:\" | grep -w id | tr : = | tr -cd '[[:alnum:]]=' | cut -d'=' -f2", returnStdout: true).trim() |
There was a problem hiding this comment.
In an ideal world, this can be simplified if ./jq would be available.
But grep, tr and cut can also manage to do it.
alexandreferris
approved these changes
Nov 27, 2023
yamilmedina
changed the title
MohamadJaara
approved these changes
Nov 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764The PR Description
What's new in this PR?
Issues
Address issue to have APKs on GH releases.
wireapp/wire#396
Causes (Optional)
Whenever a new tag is created, it will run on Jenkins the tag workflow to upload the APK to the latest release.
This only considers semantic tags and named fixed versions, to be consistent with our GH Release action.
Solutions
Use GH API to upload a release asset to a release.
Testing
Manually tested
https://10.10.124.134/blue/organizations/jenkins/AR-build-pipeline/detail/AR-build-pipeline/2021/pipeline
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.