fix: disable removing non-permanent clients [WPB-5700] #2485
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ohassine
approved these changes
Nov 29, 2023
|
Do we need it for RC ? |
|
APKs built during tests are available here. Scroll down to Artifacts! |
saleniuk
changed the title
saleniuk
requested review from
a team,
typfel,
yamilmedina,
vitorhugods,
mchenani and
Garzas
and removed request for
a team
vitorhugods
approved these changes
Nov 29, 2023
| device = Device(result.client), | ||
| isCurrentDevice = result.isCurrentClient, | ||
| removeDeviceDialogState = RemoveDeviceDialogState.Hidden | ||
| removeDeviceDialogState = RemoveDeviceDialogState.Hidden, | ||
| canBeRemoved = !result.isCurrentClient && isSelfClient && result.client.type == ClientType.Permanent, |
There was a problem hiding this comment.
Just thinking out loud: in the future, it would be nice to have this in Kalium. So Kalium can expose a isRemovable property for clients.
|
APKs built during tests are available here. Scroll down to Artifacts! |
|
APKs built during tests are available here. Scroll down to Artifacts! |
|
Build 2123 succeeded. The build produced the following APK's: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764The PR Description
What's new in this PR?
Issues
Currently, the user can remove clients of all types, even legal hold one.
Solutions
Disable the option to delete non-permanent clients.
Testing
Test Coverage (Optional)
How to Test
Have a user who has legal hold enabled, open "my devices" screen and click on "legal hold" device.
Attachments (Optional)
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.