Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: display the app lock enforce dialogue when it is enforced but no… #2487

Conversation

MohamadJaara
Copy link
Member

…t enabled in the app


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

have team settings enforced but set to not changed
then the app will not be blocked

Solutions

block the app if the team setting is enforced and the app is does not have a lock regardless of the is changed status

Dependencies (Optional)

If there are some other pull requests related to this one (e.g. new releases of frameworks), specify them here.

Needs releases with:

  • GitHub link to other pull request

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.

Notes (Optional)

Specify here any other facts that you think are important for this issue.

Attachments (Optional)

Attachments like images, videos, etc. (drag and drop in the text box)


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

Copy link
Contributor

github-actions bot commented Nov 30, 2023

Test Results

697 tests   697 ✔️  13m 20s ⏱️
  99 suites      0 💤
  99 files        0

Results for commit 527a8ba.

♻️ This comment has been updated with latest results.

@MohamadJaara MohamadJaara enabled auto-merge (squash) December 1, 2023 01:26
@MohamadJaara MohamadJaara enabled auto-merge (squash) December 1, 2023 01:26
Copy link
Contributor

github-actions bot commented Dec 1, 2023

APKs built during tests are available here. Scroll down to Artifacts!

@AndroidBob
Copy link
Collaborator

Build 2094 succeeded.

The build produced the following APK's:

@MohamadJaara MohamadJaara merged commit bbaba6f into release/candidate Dec 1, 2023
11 of 12 checks passed
@MohamadJaara MohamadJaara deleted the fix/WPB-5716-logout-and-login-again-breaks-app-lock branch December 1, 2023 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
4 participants