Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add pagination in searched messages result screen (WPB-5498) #2489

Merged
merged 20 commits into from Dec 1, 2023

Conversation

alexandreferris
Copy link
Contributor

@alexandreferris alexandreferris commented Nov 30, 2023

StoryWPB-5498 Add pagination results


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

There was a bit of a performance issue when search result was extensive.

Solutions

Added pagination to search result (now its so blazing fast that sometimes the loading icon doesn't even show 😢 )

Dependencies (Optional)

Needs releases with:

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

  • Open App
  • Open Conversation
  • Open Conversation Details
  • Open Search
  • Type a search query with many results
  • Verify that results are now faster and paginated

Copy link

codecov bot commented Nov 30, 2023

Codecov Report

Merging #2489 (c3437c3) into develop (b51377f) will increase coverage by 0.00%.
The diff coverage is 87.50%.

Additional details and impacted files
@@            Coverage Diff             @@
##             develop    #2489   +/-   ##
==========================================
  Coverage      41.47%   41.47%           
- Complexity      1104     1105    +1     
==========================================
  Files            348      348           
  Lines          12764    12771    +7     
  Branches        1664     1668    +4     
==========================================
+ Hits            5294     5297    +3     
  Misses          6976     6976           
- Partials         494      498    +4     
Files Coverage Δ
...in/kotlin/com/wire/android/mapper/MessageMapper.kt 66.00% <ø> (ø)
...search/messages/SearchConversationMessagesState.kt 100.00% <100.00%> (ø)
...ch/messages/SearchConversationMessagesViewModel.kt 80.95% <89.47%> (-1.55%) ⬇️
...secase/GetConversationMessagesFromSearchUseCase.kt 87.50% <85.00%> (-12.50%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b51377f...c3437c3. Read the comment docs.

@alexandreferris alexandreferris requested review from a team, yamilmedina, borichellow, vitorhugods, ohassine, saleniuk and MohamadJaara and removed request for a team November 30, 2023 14:17
Copy link
Contributor

github-actions bot commented Nov 30, 2023

Test Results

0 tests   - 714   0 ✔️  - 714   0s ⏱️ - 7m 49s
0 suites  -   99   0 💤 ±    0 
0 files    -   99   0 ±    0 

Results for commit d21e297. ± Comparison against base commit b51377f.

♻️ This comment has been updated with latest results.

Copy link
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

Copy link
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

Copy link
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

Copy link
Contributor

@vitorhugods vitorhugods left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only thing is that GetConversationMessagesFromSearchUseCaseTest was removed.

These tests could remain.

@alexandreferris alexandreferris added this pull request to the merge queue Nov 30, 2023
@vitorhugods vitorhugods removed this pull request from the merge queue due to a manual request Nov 30, 2023
@MohamadJaara MohamadJaara added this pull request to the merge queue Dec 1, 2023
@MohamadJaara MohamadJaara removed this pull request from the merge queue due to a manual request Dec 1, 2023
@MohamadJaara MohamadJaara merged commit 5aa2802 into develop Dec 1, 2023
13 checks passed
@MohamadJaara MohamadJaara deleted the feat/search_messages_pagination branch December 1, 2023 00:39
MohamadJaara added a commit that referenced this pull request Dec 1, 2023
…2489)

Co-authored-by: MohamadJaara <mohamad.jaara@wire.com>
Copy link
Contributor

github-actions bot commented Dec 1, 2023

APKs built during tests are available here. Scroll down to Artifacts!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
4 participants