New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add pagination in searched messages result screen (WPB-5498) #2489
Conversation
… flow and not two
# Conflicts: # kalium
...ire/android/ui/home/conversations/search/messages/SearchConversationMessagesResultsScreen.kt
Outdated
Show resolved
Hide resolved
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #2489 +/- ##
==========================================
Coverage 41.47% 41.47%
- Complexity 1104 1105 +1
==========================================
Files 348 348
Lines 12764 12771 +7
Branches 1664 1668 +4
==========================================
+ Hits 5294 5297 +3
Misses 6976 6976
- Partials 494 498 +4
Continue to review full report in Codecov by Sentry.
|
APKs built during tests are available here. Scroll down to Artifacts! |
...n/com/wire/android/ui/home/conversations/usecase/GetConversationMessagesFromSearchUseCase.kt
Outdated
Show resolved
Hide resolved
...ire/android/ui/home/conversations/search/messages/SearchConversationMessagesResultsScreen.kt
Outdated
Show resolved
Hide resolved
APKs built during tests are available here. Scroll down to Artifacts! |
APKs built during tests are available here. Scroll down to Artifacts! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only thing is that GetConversationMessagesFromSearchUseCaseTest
was removed.
These tests could remain.
…2489) Co-authored-by: MohamadJaara <mohamad.jaara@wire.com>
APKs built during tests are available here. Scroll down to Artifacts! |
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764
The PR Description
What's new in this PR?
Issues
There was a bit of a performance issue when search result was extensive.
Solutions
Added pagination to search result (now its so blazing fast that sometimes the loading icon doesn't even show 😢 )
Dependencies (Optional)
Needs releases with:
Testing
Test Coverage (Optional)
How to Test