Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: App lock does not show up after fresh install (WPB-5609) #2499

Merged

Conversation

ohassine
Copy link
Member

@ohassine ohassine commented Dec 4, 2023

BugWPB-5609 [Android] When screen locked applock doesn't start


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

On fresh install, app lock is not showing up after enabling it, putting the in background and reopening the app again.

Causes (Optional)

We were not observing current session. So every time we open the app, we use the old value returned by CurrentSessionUseCase, which is no session.
As a result the app lock status is always Disabled and no app lock will shoup

Solutions

Observe current session to get updated session value.

Needs releases with:

  • GitHub link to other pull request

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

  • Login on fresh install
  • Enable app lock and put the app in background (don't kill it)
  • Wait for the timeout(1min) and open the app again
  • You should see the app lock

PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

Copy link
Contributor

@alexandreferris alexandreferris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great catch!

@ohassine ohassine changed the title fix: App lock do not show up after fresh install (WPB-5609) fix: App lock does not show up after fresh install (WPB-5609) Dec 4, 2023
Copy link
Contributor

github-actions bot commented Dec 4, 2023

Test Results

702 tests   702 ✔️  9m 31s ⏱️
  99 suites      0 💤
  99 files        0

Results for commit 636c2f0.

Copy link
Contributor

github-actions bot commented Dec 4, 2023

APKs built during tests are available here. Scroll down to Artifacts!

@AndroidBob
Copy link
Collaborator

Build 2142 succeeded.

The build produced the following APK's:

@ohassine ohassine merged commit 646eca7 into release/candidate Dec 4, 2023
28 checks passed
@ohassine ohassine deleted the app_lock_not_showing_up_after_fresh_install branch December 4, 2023 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
5 participants