Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: handle legal hold system messages [WPB-4779] #2505

Merged
merged 21 commits into from Dec 12, 2023

Conversation

saleniuk
Copy link
Contributor

@saleniuk saleniuk commented Dec 6, 2023

StoryWPB-4779 [Android] System messages for conversations on legal hold


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

  • updated creating strings with styled parameters
  • updated legal hold indicator
  • created UI and implemented handling of legal hold system messages

Dependencies (Optional)

Needs releases with:

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

Enable or disable legal hold for a team member to see system messages.

Attachments (Optional)

self_legal_hold
other_legal_hold.mp4

PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

Copy link
Contributor

github-actions bot commented Dec 6, 2023

Test Results

726 tests  ±0   726 ✔️ ±0   10m 48s ⏱️ - 2m 19s
100 suites ±0       0 💤 ±0 
100 files   ±0       0 ±0 

Results for commit 9c71370. ± Comparison against base commit a963b92.

♻️ This comment has been updated with latest results.

@AndroidBob
Copy link
Collaborator

Build 2184 failed.

@AndroidBob
Copy link
Collaborator

Build 2186 failed.

Copy link

codecov bot commented Dec 7, 2023

Codecov Report

Merging #2505 (9c71370) into develop (a963b92) will decrease coverage by 0.09%.
The diff coverage is 16.21%.

Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #2505      +/-   ##
=============================================
- Coverage      41.28%   41.19%   -0.09%     
  Complexity      1112     1112              
=============================================
  Files            355      355              
  Lines          12902    12926      +24     
  Branches        1685     1690       +5     
=============================================
- Hits            5326     5325       -1     
- Misses          7071     7096      +25     
  Partials         505      505              
Files Coverage Δ
...secase/GetConversationMessagesFromSearchUseCase.kt 87.50% <100.00%> (ø)
...ld/dialog/requested/LegalHoldRequestedViewModel.kt 86.51% <100.00%> (ø)
...otlin/com/wire/android/util/ui/StyledStringUtil.kt 0.00% <ø> (ø)
...in/kotlin/com/wire/android/mapper/MessageMapper.kt 65.34% <0.00%> (-0.66%) ⬇️
...tions/usecase/GetMessagesForConversationUseCase.kt 0.00% <0.00%> (ø)
.../wire/android/mapper/SystemMessageContentMapper.kt 54.01% <0.00%> (-6.15%) ⬇️
...e/android/ui/home/conversations/model/UIMessage.kt 51.56% <11.76%> (-1.65%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a963b92...9c71370. Read the comment docs.

Copy link
Contributor

github-actions bot commented Dec 7, 2023

APKs built during tests are available here. Scroll down to Artifacts!

@AndroidBob
Copy link
Collaborator

Build 2187 succeeded.

The build produced the following APK's:

@saleniuk saleniuk requested review from a team, typfel, borichellow, vitorhugods, mchenani and Garzas and removed request for a team December 7, 2023 13:39
@AndroidBob
Copy link
Collaborator

Build 2225 succeeded.

The build produced the following APK's:

@AndroidBob
Copy link
Collaborator

Build 2233 succeeded.

The build produced the following APK's:

Copy link
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

@AndroidBob
Copy link
Collaborator

Build 2235 succeeded.

The build produced the following APK's:

Copy link
Member

@mchenani mchenani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@mchenani mchenani added this pull request to the merge queue Dec 12, 2023
@saleniuk saleniuk removed this pull request from the merge queue due to a manual request Dec 12, 2023
@AndroidBob
Copy link
Collaborator

Build 2239 failed.

Copy link
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

@AndroidBob
Copy link
Collaborator

Build 2244 succeeded.

The build produced the following APK's:

@saleniuk saleniuk added this pull request to the merge queue Dec 12, 2023
Merged via the queue into develop with commit ebcf86d Dec 12, 2023
15 checks passed
@saleniuk saleniuk deleted the feat/legalhold-system-messages-ui branch December 12, 2023 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
4 participants