Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Remove nearby devices permission for calling (WPB-4583) #2508

Merged
merged 3 commits into from Dec 11, 2023

Conversation

ohassine
Copy link
Member

@ohassine ohassine commented Dec 8, 2023

TaskWPB-4583 [Android] Enable joining a call without giving permissions to nearby devices


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

Nearby devices permission is required to make calls on Wire.

Causes (Optional)

After the behaviour changes that Google done on Android 12(>= API 31), nearby devices permission is required when connecting to BT devices.

Solutions

Refactor is done on AVS, on Android we just need to remove the logic to request BT permission

Needs releases with:

  • GitHub link to other pull request

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.

Notes (Optional)

Specify here any other facts that you think are important for this issue.

Attachments (Optional)

Attachments like images, videos, etc. (drag and drop in the text box)


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@ohassine ohassine changed the title Remove nearby devices permission for calling Remove nearby devices permission for calling (WPB-4583) Dec 8, 2023
@ohassine ohassine changed the title Remove nearby devices permission for calling (WPB-4583) feat: Remove nearby devices permission for calling (WPB-4583) Dec 8, 2023
Copy link

codecov bot commented Dec 8, 2023

Codecov Report

Merging #2508 (8db820a) into develop (d75f286) will increase coverage by 0.01%.
The diff coverage is 0.00%.

Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #2508      +/-   ##
=============================================
+ Coverage      41.26%   41.28%   +0.01%     
  Complexity      1112     1112              
=============================================
  Files            355      355              
  Lines          12906    12902       -4     
  Branches        1687     1685       -2     
=============================================
  Hits            5326     5326              
+ Misses          7075     7071       -4     
  Partials         505      505              
Files Coverage Δ
...id/ui/home/conversationslist/ConversationRouter.kt 0.00% <ø> (ø)
...d/util/permission/CallingRecordAudioRequestFlow.kt 0.00% <0.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d75f286...8db820a. Read the comment docs.

Copy link
Contributor

github-actions bot commented Dec 8, 2023

Test Results

726 tests  ±0   726 ✔️ ±0   11m 6s ⏱️ + 2m 38s
100 suites ±0       0 💤 ±0 
100 files   ±0       0 ±0 

Results for commit 8db820a. ± Comparison against base commit d75f286.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Dec 8, 2023

APKs built during tests are available here. Scroll down to Artifacts!

Copy link
Contributor

github-actions bot commented Dec 8, 2023

APKs built during tests are available here. Scroll down to Artifacts!

@AndroidBob
Copy link
Collaborator

Build 2211 succeeded.

The build produced the following APK's:

@ohassine ohassine added this pull request to the merge queue Dec 11, 2023
Merged via the queue into develop with commit 43d336e Dec 11, 2023
14 checks passed
@ohassine ohassine deleted the remove_nearby_devices_permission_for_calling branch December 11, 2023 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
4 participants