New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Remove nearby devices permission for calling (WPB-4583) #2508
feat: Remove nearby devices permission for calling (WPB-4583) #2508
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #2508 +/- ##
=============================================
+ Coverage 41.26% 41.28% +0.01%
Complexity 1112 1112
=============================================
Files 355 355
Lines 12906 12902 -4
Branches 1687 1685 -2
=============================================
Hits 5326 5326
+ Misses 7075 7071 -4
Partials 505 505
Continue to review full report in Codecov by Sentry.
|
APKs built during tests are available here. Scroll down to Artifacts! |
APKs built during tests are available here. Scroll down to Artifacts! |
Build 2211 succeeded. The build produced the following APK's: |
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764
The PR Description
What's new in this PR?
Issues
Nearby devices permission is required to make calls on Wire.
Causes (Optional)
After the behaviour changes that Google done on Android 12(>= API 31), nearby devices permission is required when connecting to BT devices.
Solutions
Refactor is done on AVS, on Android we just need to remove the logic to request BT permission
Needs releases with:
Testing
Test Coverage (Optional)
How to Test
Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.
Notes (Optional)
Specify here any other facts that you think are important for this issue.
Attachments (Optional)
Attachments like images, videos, etc. (drag and drop in the text box)
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764
.