Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: video call icon [WPB-3667] #2529

Merged
merged 1 commit into from Dec 15, 2023
Merged

feat: video call icon [WPB-3667] #2529

merged 1 commit into from Dec 15, 2023

Conversation

Garzas
Copy link
Contributor

@Garzas Garzas commented Dec 15, 2023 •
edited by github-actions bot

StoryWPB-3667 [UI] Change "call" icon in conversation view page header

PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³

  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Added new video call icon

video_call_icon

@Garzas Garzas requested review from alexandreferris, ohassine and a team December 15, 2023 02:18
@Garzas Garzas self-assigned this Dec 15, 2023
@Garzas Garzas requested review from borichellow, MohamadJaara and saleniuk and removed request for a team December 15, 2023 02:18
@github-actions GitHub Actions
Copy link
Contributor

Test Results

733 tests  ±0   733 ✔️ ±0   8m 19s ⏱️ - 1m 29s
101 suites ±0       0 💤 ±0 
101 files   ±0       0 ❌ ±0 

Results for commit cee0420. ± Comparison against base commit 2c87930.

@github-actions GitHub Actions
Copy link
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

@AndroidBob
Copy link
Collaborator

Build 2309 succeeded.

The build produced the following APK's:

@Garzas Garzas added this pull request to the merge queue Dec 15, 2023
Merged via the queue into develop with commit 40d8175 Dec 15, 2023
21 checks passed
@Garzas Garzas deleted the feat/video-call-icon branch December 15, 2023 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ohassine ohassine ohassine approved these changes

@saleniuk saleniuk saleniuk approved these changes

@alexandreferris alexandreferris Awaiting requested review from alexandreferris

@borichellow borichellow Awaiting requested review from borichellow borichellow was automatically assigned from wireapp/android

@MohamadJaara MohamadJaara Awaiting requested review from MohamadJaara MohamadJaara was automatically assigned from wireapp/android

Assignees

@Garzas Garzas

Labels
size/M
Projects
None yet
Milestone
No milestone
4 participants
@Garzas @AndroidBob @ohassine @saleniuk