Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support new reason value on conversation leave event #2536

Merged

Conversation

MohamadJaara
Copy link
Member


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

the team member leave message content is changed to include a list of user ids instead of user names, just like member leave

Solutions

add the new message type and deptecate the old one

Dependencies (Optional)

If there are some other pull requests related to this one (e.g. new releases of frameworks), specify them here.

Needs releases with:

  • GitHub link to other pull request

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.

Notes (Optional)

Specify here any other facts that you think are important for this issue.

Attachments (Optional)

Attachments like images, videos, etc. (drag and drop in the text box)


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

…tion-leave-evetn

# Conflicts:
#	app/src/main/kotlin/com/wire/android/ui/home/conversations/SystemMessageItem.kt
#	app/src/main/kotlin/com/wire/android/ui/home/conversations/model/UIMessage.kt
#	app/src/main/kotlin/com/wire/android/util/ui/StyledStringUtil.kt
#	kalium
@AndroidBob
Copy link
Collaborator

Build 2327 failed.

@AndroidBob
Copy link
Collaborator

Build 2328 succeeded.

The build produced the following APK's:

Copy link

codecov bot commented Dec 17, 2023

Codecov Report

Merging #2536 (ceb11d0) into develop (40d8175) will decrease coverage by 0.13%.
Report is 1 commits behind head on develop.
The diff coverage is 11.32%.

Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #2536      +/-   ##
=============================================
- Coverage      41.21%   41.08%   -0.13%     
  Complexity      1118     1118              
=============================================
  Files            357      358       +1     
  Lines          13040    13086      +46     
  Branches        1703     1709       +6     
=============================================
+ Hits            5375     5377       +2     
- Misses          7158     7201      +43     
- Partials         507      508       +1     
Files Coverage Δ
.../wire/android/mapper/SystemMessageContentMapper.kt 52.14% <0.00%> (-1.88%) ⬇️
...om/wire/android/util/ui/LocalizedStringResource.kt 6.66% <6.66%> (ø)
...e/android/ui/home/conversations/model/UIMessage.kt 48.28% <14.70%> (-3.29%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bf53877...ceb11d0. Read the comment docs.

Copy link
Contributor

Test Results

733 tests   733 ✔️  7m 52s ⏱️
101 suites      0 💤
101 files        0

Results for commit ceb11d0.

Copy link
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

@MohamadJaara MohamadJaara requested review from a team, typfel, yamilmedina, alexandreferris, borichellow and Garzas and removed request for a team December 17, 2023 17:27
@vitorhugods vitorhugods changed the title feat: support new reason value on conversation leave evetn feat: support new reason value on conversation leave event Dec 17, 2023
@MohamadJaara MohamadJaara added this pull request to the merge queue Dec 18, 2023
Merged via the queue into develop with commit aaa2d87 Dec 18, 2023
17 checks passed
@MohamadJaara MohamadJaara deleted the feat/support-new-reason-value-on-conversation-leave-evetn branch December 18, 2023 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
4 participants