Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(e2ei): use refresh token for idp authorization (WPB-5880) #2549

Merged
merged 4 commits into from Dec 21, 2023

Conversation

mchenani
Copy link
Member

@mchenani mchenani commented Dec 21, 2023

StoryWPB-5880 [Android] Use OAuth Refresh Token for Renewal Process


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Using oAuth refresh token if exist to get the oAuth id token without enforcing the user to login again.


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

Copy link
Contributor

github-actions bot commented Dec 21, 2023

Test Results

737 tests  ±0   737 ✔️ ±0   7m 6s ⏱️ +3s
101 suites ±0       0 💤 ±0 
101 files   ±0       0 ±0 

Results for commit 3e23a88. ± Comparison against base commit 6b43eed.

♻️ This comment has been updated with latest results.

@AndroidBob
Copy link
Collaborator

Build 2418 failed.

Copy link
Contributor

@yamilmedina yamilmedina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🏎️

@AndroidBob
Copy link
Collaborator

Build 2421 failed.

@mchenani mchenani added this pull request to the merge queue Dec 21, 2023
Copy link

codecov bot commented Dec 21, 2023

Codecov Report

Attention: 22 lines in your changes are missing coverage. Please review.

Comparison is base (6b43eed) 41.00% compared to head (3e23a88) 40.96%.

Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #2549      +/-   ##
=============================================
- Coverage      41.00%   40.96%   -0.04%     
  Complexity      1128     1128              
=============================================
  Files            358      358              
  Lines          13103    13115      +12     
  Branches        1725     1726       +1     
=============================================
  Hits            5373     5373              
- Misses          7210     7222      +12     
  Partials         520      520              
Files Coverage Δ
.../android/feature/e2ei/GetE2EICertificateUseCase.kt 0.00% <0.00%> (ø)
...tlin/com/wire/android/feature/e2ei/OAuthUseCase.kt 0.00% <0.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6b43eed...3e23a88. Read the comment docs.

Copy link
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

Merged via the queue into develop with commit 8a9969a Dec 21, 2023
14 of 15 checks passed
@mchenani mchenani deleted the feat/oauth/use-oauth-refresh-token branch December 21, 2023 18:10
@AndroidBob
Copy link
Collaborator

Build 2422 succeeded.

The build produced the following APK's:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
5 participants