Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: focus input after rich text option [WPB-4254] #2550

Merged
merged 2 commits into from Dec 22, 2023
Merged

fix: focus input after rich text option [WPB-4254] #2550

merged 2 commits into from Dec 22, 2023

Conversation

Garzas
Copy link
Contributor

@Garzas Garzas commented Dec 22, 2023 •
edited by github-actions bot

BugWPB-4254 [Android] When selecting text format without tapping in text input field, my typing indicator could be at the wrong position

PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³

  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

  • focus automatically when user clicks on rich text options
focus_on_rich_text.mp4

@Garzas Garzas self-assigned this Dec 22, 2023
@github-actions GitHub Actions
Copy link
Contributor

Test Results

737 tests  ±0   737 ✔️ ±0   5m 51s ⏱️ - 5m 29s
101 suites ±0       0 💤 ±0 
101 files   ±0       0 ❌ ±0 

Results for commit c4fefad. ± Comparison against base commit 8a9969a.

@github-actions GitHub Actions
Copy link
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

@AndroidBob
Copy link
Collaborator

Build 2425 succeeded.

The build produced the following APK's:

@Garzas Garzas added this pull request to the merge queue Dec 22, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 22, 2023
@Garzas Garzas added this pull request to the merge queue Dec 22, 2023
Merged via the queue into develop with commit d4a218c Dec 22, 2023
21 checks passed
@Garzas Garzas deleted the fix/focus-input-after-rich-text-option branch December 22, 2023 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@borichellow borichellow borichellow approved these changes

@saleniuk saleniuk saleniuk approved these changes

Assignees

@Garzas Garzas

Labels
size/XS
Projects
None yet
Milestone
No milestone
4 participants
@Garzas @AndroidBob @borichellow @saleniuk