New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: discover legal hold when sending message [WPB-5999] #2558
feat: discover legal hold when sending message [WPB-5999] #2558
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #2558 +/- ##
=============================================
+ Coverage 41.16% 41.25% +0.08%
- Complexity 1134 1138 +4
=============================================
Files 361 361
Lines 13160 13183 +23
Branches 1733 1738 +5
=============================================
+ Hits 5417 5438 +21
+ Misses 7216 7214 -2
- Partials 527 531 +4
Continue to review full report in Codecov by Sentry.
|
Test Results741 tests +3 741 ✅ +3 9m 22s ⏱️ +46s Results for commit 0d453cb. ± Comparison against base commit d141853. This pull request removes 3 and adds 6 tests. Note that renamed tests count towards both.
♻️ This comment has been updated with latest results. |
APKs built during tests are available here. Scroll down to Artifacts! |
…l-hold-when-sending-message # Conflicts: # kalium
APKs built during tests are available here. Scroll down to Artifacts! |
APKs built during tests are available here. Scroll down to Artifacts! |
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764
The PR Description
What's new in this PR?
Issues
We need to discover missing/deleted legal hold clients and changes in legal hold for conversation on Android when sending messages and handle this change properly by showing system messages. If the legal hold status for conversation changed when sending a message, the user needs to be informed about that and decide whether he/she still wants to resend the message.
Solutions
Handle new type of failure
LegalHoldEnabledForConversationFailure
when sending a message and show a dialog informing the user that this conversation is under legal hold and give him/her option to decide whether he/she still wants to resend that message.Dependencies (Optional)
Needs releases with:
Testing
Test Coverage (Optional)
How to Test
Enable legal hold for some other member before logging in and syncing, then login - at this point the app doesn't yet know that a conversation or member is under legal hold, but after sending first message, it should be handled properly.
Attachments (Optional)
legal_hold_discovery_send_message.mov
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764
.