Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove deprecated accompanist-navigation dependency #2568

Merged
merged 2 commits into from Jan 9, 2024

Conversation

ohassine
Copy link
Member

@ohassine ohassine commented Jan 5, 2024


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

accompanist-navigation is deprecated

Solutions

Migrate to androidx.navigation.compose

Dependencies (Optional)

If there are some other pull requests related to this one (e.g. new releases of frameworks), specify them here.

Needs releases with:

  • GitHub link to other pull request

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.

Notes (Optional)

Specify here any other facts that you think are important for this issue.

Attachments (Optional)

Attachments like images, videos, etc. (drag and drop in the text box)


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@ohassine ohassine requested review from a team, typfel, yamilmedina, alexandreferris, borichellow and mchenani and removed request for a team January 5, 2024 17:26
Copy link
Contributor

github-actions bot commented Jan 5, 2024

Test Results

742 tests  +1   742 ✅ +1   11m 5s ⏱️ +10s
102 suites ±0     0 💤 ±0 
102 files   ±0     0 ❌ ±0 

Results for commit 0834dc8. ± Comparison against base commit c38ab0f.

♻️ This comment has been updated with latest results.

@AndroidBob
Copy link
Collaborator

Build 2469 failed.

Copy link

codecov bot commented Jan 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c38ab0f) 41.24% compared to head (0834dc8) 41.23%.
Report is 3 commits behind head on develop.

Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #2568      +/-   ##
=============================================
- Coverage      41.24%   41.23%   -0.01%     
  Complexity      1138     1138              
=============================================
  Files            361      361              
  Lines          13190    13202      +12     
  Branches        1739     1743       +4     
=============================================
+ Hits            5440     5444       +4     
- Misses          7219     7226       +7     
- Partials         531      532       +1     

see 249 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c38ab0f...0834dc8. Read the comment docs.

Copy link
Contributor

github-actions bot commented Jan 9, 2024

APKs built during tests are available here. Scroll down to Artifacts!

@ohassine ohassine added this pull request to the merge queue Jan 9, 2024
Merged via the queue into develop with commit 2124283 Jan 9, 2024
13 of 14 checks passed
@ohassine ohassine deleted the remove_accompanist_navigation branch January 9, 2024 09:22
@AndroidBob
Copy link
Collaborator

Build 2487 succeeded.

The build produced the following APK's:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
4 participants