feat(mls): handle unsupported protocol case [WPB-5047] #2579
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vitorhugods
requested review from
a team,
typfel,
yamilmedina,
mchenani,
ohassine and
saleniuk
and removed request for
a team
Test Results742 tests 742 ✅ 9m 24s ⏱️ Results for commit 1bcde49. ♻️ This comment has been updated with latest results. |
|
APKs built during tests are available here. Scroll down to Artifacts! |
|
Build 2520 succeeded. The build produced the following APK's: |
ohassine
approved these changes
Jan 12, 2024
The MessageComposer has been updated to handle an UnsupportedProtocol case. This case renders a disabled message composer with a warning message. This warning informs users that the conversation is using an unsupported encryption protocol.
vitorhugods
force-pushed
the
feat/mls/inform-that-user-doesnt-support-protocol
branch
from
7de3c30
to
1bcde49
Compare
|
APKs built during tests are available here. Scroll down to Artifacts! |
|
Build 2533 succeeded. The build produced the following APK's: |
yamilmedina
approved these changes
Jan 12, 2024
vitorhugods
deleted the
feat/mls/inform-that-user-doesnt-support-protocol
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764The PR Description
What's new in this PR?
Issues
When a conversation is using a protocol that the device doesn't support. We need to lock the conversation UI and inform the user the reason.
Solutions
The
MessageComposerwas been updated to handle an UnsupportedProtocol case. This case renders a disabled message composer with a warning message. This warning informs users that the conversation is using an unsupported encryption protocol.Dependencies
Needs releases with:
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.