Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: set modifier of LazyColumn to fillMaxSize (WPB-6121) #2591

Merged
merged 1 commit into from Jan 17, 2024

Conversation

alexandreferris
Copy link
Contributor

@alexandreferris alexandreferris commented Jan 17, 2024

BugWPB-6121 [Android] When selecting "files" tab in Media Gallery, items are jumping from center to top of the screen


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

When opening media gallery and selecting FILES tab, the items would jump from the center to the top of the screen (being the top the correct one)

Causes (Optional)

There was no set for size of LazyColumn

Solutions

Add fillMaxSize to modifier of LazyColumn so its always the screen size, so no jumping around :)

Testing

How to Test

  • Open Media Gallery (with 1 item, so its better visualized)
  • Items should not be shown on center of screen and then jumped to the top (check Task video for more info)
  • Items should be already at the top of the screen

@alexandreferris alexandreferris requested review from a team, typfel, borichellow, Garzas, ohassine and saleniuk and removed request for a team January 17, 2024 12:44
Copy link

codecov bot commented Jan 17, 2024

Codecov Report

Attention: 64 lines in your changes are missing coverage. Please review.

Comparison is base (b15453f) 41.39% compared to head (36df05c) 41.29%.
Report is 5 commits behind head on develop.

Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #2591      +/-   ##
=============================================
- Coverage      41.39%   41.29%   -0.10%     
- Complexity      1129     1130       +1     
=============================================
  Files            361      364       +3     
  Lines          13255    13323      +68     
  Branches        1742     1748       +6     
=============================================
+ Hits            5487     5502      +15     
- Misses          7236     7289      +53     
  Partials         532      532              
Files Coverage Δ
.../android/ui/authentication/devices/model/Device.kt 95.00% <100.00%> (+0.55%) ⬆️
...droid/ui/home/messagecomposer/AttachmentOptions.kt 0.00% <ø> (ø)
.../messagecomposer/state/MessageCompositionHolder.kt 33.62% <100.00%> (+1.50%) ⬆️
.../ui/home/conversations/MessageComposerViewModel.kt 81.96% <71.42%> (+0.30%) ⬆️
...ndroid/ui/settings/devices/SelfDevicesViewModel.kt 85.29% <60.00%> (-2.21%) ⬇️
...messagecomposer/state/AdditionalOptionMenuState.kt 43.75% <25.00%> (-1.71%) ⬇️
...e/android/ui/home/conversations/model/UIMessage.kt 47.30% <20.00%> (+0.13%) ⬆️
...home/messagecomposer/location/GeoLocatedAddress.kt 0.00% <0.00%> (ø)
...essagecomposer/state/MessageComposerStateHolder.kt 55.55% <0.00%> (-5.06%) ⬇️
...roid/util/permission/CurrentLocationRequestFlow.kt 0.00% <0.00%> (ø)
... and 2 more

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8cd101e...36df05c. Read the comment docs.

Copy link
Contributor

Test Results

744 tests   744 ✅  11m 49s ⏱️
102 suites    0 💤
102 files      0 ❌

Results for commit 36df05c.

Copy link
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

@AndroidBob
Copy link
Collaborator

Build 2618 succeeded.

The build produced the following APK's:

@alexandreferris alexandreferris added this pull request to the merge queue Jan 17, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 17, 2024
@alexandreferris alexandreferris added this pull request to the merge queue Jan 17, 2024
Merged via the queue into develop with commit 7b439b9 Jan 17, 2024
15 checks passed
@alexandreferris alexandreferris deleted the fix/media_gallery_assets_jumping branch January 17, 2024 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
4 participants