New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: set modifier of LazyColumn to fillMaxSize (WPB-6121) #2591
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #2591 +/- ##
=============================================
- Coverage 41.39% 41.29% -0.10%
- Complexity 1129 1130 +1
=============================================
Files 361 364 +3
Lines 13255 13323 +68
Branches 1742 1748 +6
=============================================
+ Hits 5487 5502 +15
- Misses 7236 7289 +53
Partials 532 532
Continue to review full report in Codecov by Sentry.
|
Test Results744 tests 744 ✅ 11m 49s ⏱️ Results for commit 36df05c. |
APKs built during tests are available here. Scroll down to Artifacts! |
Build 2618 succeeded. The build produced the following APK's: |
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764
The PR Description
What's new in this PR?
Issues
When opening media gallery and selecting
FILES
tab, the items would jump from the center to the top of the screen (being the top the correct one)Causes (Optional)
There was no set for size of
LazyColumn
Solutions
Add
fillMaxSize
to modifier ofLazyColumn
so its always the screen size, so no jumping around :)Testing
How to Test