Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Show a dialog when current client's certificate is revoked (WPB-6145) - cherrypick #2635

Conversation

ohassine
Copy link
Member

@ohassine ohassine commented Jan 26, 2024

TaskWPB-6145 [Android] Show Your Device's Cert Revoked


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Cherry-pick of #2594

Dependencies (Optional)

If there are some other pull requests related to this one (e.g. new releases of frameworks), specify them here.

Needs releases with:

  • GitHub link to other pull request

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.

Notes (Optional)

Specify here any other facts that you think are important for this issue.

Attachments (Optional)

Attachments like images, videos, etc. (drag and drop in the text box)


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@ohassine ohassine changed the title feat: Show a dialog when current client's certificate is revoked (WPB-6145) feat: Show a dialog when current client's certificate is revoked (WPB-6145) - cherrypick Jan 26, 2024
@ohassine ohassine requested review from a team, yamilmedina, MohamadJaara, vitorhugods and Garzas and removed request for a team January 26, 2024 14:01
Copy link
Contributor

Test Results

753 tests   753 ✅  11m 30s ⏱️
106 suites    0 💤
106 files      0 ❌

Results for commit e21e115.

Copy link
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

@AndroidBob
Copy link
Collaborator

Build 2786 succeeded.

The build produced the following APK's:

@ohassine ohassine merged commit b62d100 into release/candidate Jan 26, 2024
13 of 14 checks passed
@ohassine ohassine deleted the feat_Show_a_dialog_when_current_client's_certificate_is_revoked branch January 26, 2024 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
4 participants