fix: not possible to search for services [WPB-5943] #2648
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MohamadJaara
requested review from
a team,
typfel,
yamilmedina,
vitorhugods,
mchenani and
ohassine
and removed request for
a team
Test Results753 tests 753 ✅ 12m 8s ⏱️ Results for commit 9c65c1b. |
|
APKs built during tests are available here. Scroll down to Artifacts! |
|
Build 2812 succeeded. The build produced the following APK's: |
yamilmedina
approved these changes
Jan 31, 2024
saleniuk
approved these changes
Jan 31, 2024
…ssible-to-search-for-a-service
yamilmedina
deleted the
fix/WPB-5943-android-its-not-possible-to-search-for-a-service
branch
|
APKs built during tests are available here. Scroll down to Artifacts! |
|
Build 2822 failed. |
MohamadJaara
added a commit
that referenced
this pull request
Feb 6, 2024
Co-authored-by: Yamil Medina <yamilmedina@users.noreply.github.com> (cherry picked from commit 9350830)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764The PR Description
What's new in this PR?
Issues
when trying to search for services, the keyboard closes immediately
Solutions
there is a LaunchedEffect in the search services screen that will close the keyboard when opned
Dependencies (Optional)
If there are some other pull requests related to this one (e.g. new releases of frameworks), specify them here.
Needs releases with:
Testing
Test Coverage (Optional)
How to Test
Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.
Notes (Optional)
Specify here any other facts that you think are important for this issue.
Attachments (Optional)
Attachments like images, videos, etc. (drag and drop in the text box)
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.