fix: make SelfDeletionTimerTest unit instead of instrumented #2657
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results788 tests 788 ✅ 9m 21s ⏱️ Results for commit c8b014f. ♻️ This comment has been updated with latest results. |
|
APKs built during tests are available here. Scroll down to Artifacts! |
|
Build 2844 succeeded. The build produced the following APK's: |
yamilmedina
approved these changes
Feb 2, 2024
saleniuk
requested review from
a team,
typfel,
alexandreferris,
vitorhugods and
mchenani
and removed request for
a team
borichellow
approved these changes
Feb 2, 2024
7 tasks
…t-from-instrumented-to-unit
6 tasks
alexandreferris
approved these changes
Feb 2, 2024
yamilmedina
deleted the
fix/change-selfdeletiontimertest-from-instrumented-to-unit
branch
|
APKs built during tests are available here. Scroll down to Artifacts! |
|
Build 2848 succeeded. The build produced the following APK's: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764The PR Description
What's new in this PR?
These tests are failing on CI on emulator with Android 10, not sure why, but it's also not necessary for these tests to be instrumented just because it uses string resources, so I changed it to be unit test which uses mocked interface to provide string resources.
Testing
Test Coverage (Optional)
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.