fix: 2FA support dark mode #2699
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
APKs built during tests are available here. Scroll down to Artifacts! |
|
Build 3102 succeeded. The build produced the following APK's: |
ohassine
approved these changes
Feb 13, 2024
saleniuk
approved these changes
Feb 15, 2024
|
APKs built during tests are available here. Scroll down to Artifacts! |
|
Build 3204 succeeded. The build produced the following APK's: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry pick from the original PR:
kalium
What's new in this PR?
Issues
Textst in 2FA screen doesn't adopt to DarkMode
Causes (Optional)
wasn't implemented
Solutions
implement it
Attachments (Optional)
<img width=285 alt=Screenshot 2024-02-13 at 14 22 38 src=https://github.com/wireapp/wire-android/assets/6539347/59005c10-3a94-48a1-a4d2-2cef93a2bb3b>