Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: crash when answering a call (WPB-6183) - cherrypick #2705

Merged
merged 3 commits into from Feb 14, 2024

Conversation

ohassine
Copy link
Member

@ohassine ohassine commented Feb 14, 2024

BugWPB-6183 [Android] crashes during 2024-01-17 playtest answering calls


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Description

Cherrypick of #2682

Dependencies (Optional)

If there are some other pull requests related to this one (e.g. new releases of frameworks), specify them here.

Needs releases with:

  • GitHub link to other pull request

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.

Notes (Optional)

Specify here any other facts that you think are important for this issue.

Attachments (Optional)

Attachments like images, videos, etc. (drag and drop in the text box)


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@ohassine ohassine requested review from a team, typfel, alexandreferris, MohamadJaara, vitorhugods and mchenani and removed request for a team February 14, 2024 09:30
Copy link
Contributor

Test Results

802 tests   802 ✅  8m 9s ⏱️
108 suites    0 💤
108 files      0 ❌

Results for commit 3b90202.

Copy link
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

@ohassine ohassine enabled auto-merge (squash) February 14, 2024 10:18
@ohassine ohassine merged commit 275ba25 into release/candidate Feb 14, 2024
13 of 14 checks passed
@ohassine ohassine deleted the crash_answering_call_rc branch February 14, 2024 10:19
@AndroidBob
Copy link
Collaborator

Build 3126 succeeded.

The build produced the following APK's:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
4 participants