fix: Localised DateFormat in device info #2785
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #2785 +/- ##
===========================================
- Coverage 43.47% 43.47% -0.01%
===========================================
Files 411 411
Lines 13867 13872 +5
Branches 2517 2518 +1
===========================================
+ Hits 6029 6031 +2
- Misses 7130 7132 +2
- Partials 708 709 +1
Continue to review full report in Codecov by Sentry.
|
|
APKs built during tests are available here. Scroll down to Artifacts! |
|
Build 3546 succeeded. The build produced the following APK's: |
ohassine
approved these changes
Mar 12, 2024
|
Build 3558 failed. |
yamilmedina
approved these changes
Mar 12, 2024
|
Build 3566 failed. |
…_format_in_device_info-cherry-pick # Conflicts: # kalium
|
APKs built during tests are available here. Scroll down to Artifacts! |
ohassine
deleted the
fix/localised_date_format_in_device_info-cherry-pick
branch
|
Build 3571 succeeded. The build produced the following APK's: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry pick from the original PR:
kalium
What's new in this PR?
Issues
Devices screen - Time and date format not respecting locale
Causes (Optional)
Was not implemented
Solutions
implement it
Attachments (Optional)
<img width=378 alt=Screenshot 2024-03-11 at 23 32 11 src=https://github.com/wireapp/wire-android/assets/6539347/23e06ab6-df18-40f6-a965-6c4c299b958e>