Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove duplicated enroll e2ei use case #2789

Merged

Conversation

AndroidBob
Copy link
Collaborator

Cherry pick from the original PR:


⚠️ Conflicts during cherry-pick:
kalium


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

remove duplicated enroll e2ei use case

Solutions

Briefly describe the solutions you have implemented for the issues explained above.

Dependencies (Optional)

If there are some other pull requests related to this one (e.g. new releases of frameworks), specify them here.

Needs releases with:

  • GitHub link to other pull request

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.

Notes (Optional)

Specify here any other facts that you think are important for this issue.

Attachments (Optional)

Attachments like images, videos, etc. (drag and drop in the text box)


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. .

@AndroidBob AndroidBob added the cherry-pick PR is cherry-picking changes from another banch label Mar 13, 2024
Copy link
Contributor

github-actions bot commented Mar 13, 2024

Test Results

860 tests  ±0   860 ✅ ±0   13m 32s ⏱️ + 4m 50s
117 suites ±0     0 💤 ±0 
117 files   ±0     0 ❌ ±0 

Results for commit 74d6fb1. ± Comparison against base commit df1c124.

♻️ This comment has been updated with latest results.

Copy link
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

@AndroidBob
Copy link
Collaborator Author

Build 3591 succeeded.

The build produced the following APK's:

Copy link

codecov bot commented Mar 15, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 43.56%. Comparing base (df1c124) to head (74d6fb1).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2789      +/-   ##
===========================================
+ Coverage    43.53%   43.56%   +0.03%     
===========================================
  Files          413      413              
  Lines        13900    13902       +2     
  Branches      2516     2516              
===========================================
+ Hits          6051     6057       +6     
+ Misses        7137     7132       -5     
- Partials       712      713       +1     
Files Coverage Δ
...d/ui/e2eiEnrollment/GetE2EICertificateViewModel.kt 0.00% <0.00%> (ø)

... and 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update df1c124...74d6fb1. Read the comment docs.

Copy link
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

@AndroidBob
Copy link
Collaborator Author

Build 3627 succeeded.

The build produced the following APK's:

@MohamadJaara MohamadJaara added this pull request to the merge queue Mar 15, 2024
Merged via the queue into develop with commit f881a15 Mar 15, 2024
15 checks passed
@MohamadJaara MohamadJaara deleted the chore/remove-duplicated-e2ei-erolment-usecase-cherry-pick branch March 15, 2024 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick PR is cherry-picking changes from another banch size/XS
Projects
None yet
3 participants