Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add a crl revocation list to debug screen #2804

Conversation

AndroidBob
Copy link
Collaborator

Cherry pick from the original PR:


⚠️ Conflicts during cherry-pick:
kalium


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

add a crl revocation list to debug screen

Causes (Optional)

Briefly describe the causes behind the issues. This could be helpful to understand the adopted solutions behind some nasty bugs or complex issues.

Solutions

Briefly describe the solutions you have implemented for the issues explained above.

Dependencies (Optional)

If there are some other pull requests related to this one (e.g. new releases of frameworks), specify them here.

Needs releases with:

  • GitHub link to other pull request

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.

Notes (Optional)

Specify here any other facts that you think are important for this issue.

Attachments (Optional)

Attachments like images, videos, etc. (drag and drop in the text box)


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. .

@AndroidBob AndroidBob added the cherry-pick PR is cherry-picking changes from another banch label Mar 21, 2024
Copy link
Contributor

@AndroidBob looks like you are rolling back kalium to a previous commitish.

This means that the PR's target branch (develop) is using a newer version of Kalium, and the changes in this PR will rollback Kalium to an older version.

develop This PR
4be820aa2bb05ffc40a8ec1709660b16cbe6bfdd 91a09ffd30ca372196420b1ef650c71d2e09fdef

Is this intentional?

Copy link
Contributor

github-actions bot commented Mar 21, 2024

Test Results

890 tests  ±0   890 ✅ ±0   9m 2s ⏱️ - 6m 11s
122 suites ±0     0 💤 ±0 
122 files   ±0     0 ❌ ±0 

Results for commit 6d96f74. ± Comparison against base commit 1f2734d.

♻️ This comment has been updated with latest results.

@AndroidBob
Copy link
Collaborator Author

Build 3682 failed.

Copy link

codecov bot commented Mar 22, 2024

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 43.67%. Comparing base (06d1399) to head (89ecea1).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2804      +/-   ##
===========================================
+ Coverage    43.64%   43.67%   +0.03%     
===========================================
  Files          418      418              
  Lines        14005    14009       +4     
  Branches      2532     2532              
===========================================
+ Hits          6112     6118       +6     
+ Misses        7180     7177       -3     
- Partials       713      714       +1     
Files Coverage Δ
...tlin/com/wire/android/ui/debug/DebugDataOptions.kt 0.00% <0.00%> (ø)

... and 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 06d1399...89ecea1. Read the comment docs.

Copy link
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

@AndroidBob
Copy link
Collaborator Author

Build 3702 failed.

…-to-the-debug-screen-cherry-pick

# Conflicts:
#	kalium
Copy link
Contributor

github-actions bot commented Apr 8, 2024

@AndroidBob looks like you are rolling back kalium to a previous commitish.

This means that the PR's target branch (develop) is using a newer version of Kalium, and the changes in this PR will rollback Kalium to an older version.

develop This PR
8e94e8a026ac5c64c456e3717f7ea2dbe7860c64 7701db885f6bb593b0dbfb8defeae06c995ef5f2

Is this intentional?

@AndroidBob
Copy link
Collaborator Author

Build 4040 failed.

…add-a-button-to-check-crl-revocation-to-the-debug-screen-cherry-pick

# Conflicts:
#	app/src/main/kotlin/com/wire/android/ui/debug/DebugDataOptions.kt
#	kalium
@AndroidBob
Copy link
Collaborator Author

Build 4138 failed.

@AndroidBob
Copy link
Collaborator Author

Build 4143 failed.

…add-a-button-to-check-crl-revocation-to-the-debug-screen-cherry-pick
…add-a-button-to-check-crl-revocation-to-the-debug-screen-cherry-pick
@AndroidBob
Copy link
Collaborator Author

Build 4159 failed.

…add-a-button-to-check-crl-revocation-to-the-debug-screen-cherry-pick
@MohamadJaara MohamadJaara added this pull request to the merge queue Apr 12, 2024
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 43.75%. Comparing base (1f2734d) to head (6d96f74).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2804      +/-   ##
===========================================
- Coverage    43.81%   43.75%   -0.06%     
===========================================
  Files          432      432              
  Lines        14170    14174       +4     
  Branches      2457     2457              
===========================================
- Hits          6208     6202       -6     
- Misses        7269     7280      +11     
+ Partials       693      692       -1     
Files Coverage Δ
...tlin/com/wire/android/ui/debug/DebugDataOptions.kt 0.00% <0.00%> (ø)

... and 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1f2734d...6d96f74. Read the comment docs.

Copy link
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

Merged via the queue into develop with commit ca15e59 Apr 12, 2024
11 of 12 checks passed
@MohamadJaara MohamadJaara deleted the feat/add-a-button-to-check-crl-revocation-to-the-debug-screen-cherry-pick branch April 12, 2024 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick PR is cherry-picking changes from another banch size/XS
Projects
None yet
4 participants