fix: misleading dialog copy when certificate enrolling fails (WPB-7129) #2807
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexandreferris
requested review from
a team,
typfel,
yamilmedina,
borichellow,
MohamadJaara and
saleniuk
and removed request for
a team
|
APKs built during tests are available here. Scroll down to Artifacts! |
|
Build 3707 failed. |
alexandreferris
approved these changes
Mar 23, 2024
…te_enrolling_fails-cherry-pick
saleniuk
approved these changes
Mar 25, 2024
borichellow
approved these changes
Mar 25, 2024
yamilmedina
approved these changes
Mar 25, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #2807 +/- ##
===========================================
+ Coverage 43.61% 43.65% +0.04%
===========================================
Files 418 418
Lines 14007 14007
Branches 2536 2536
===========================================
+ Hits 6109 6115 +6
+ Misses 7181 7174 -7
- Partials 717 718 +1 see 2 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
github-merge-queue
bot
removed this pull request from the merge queue due to a conflict with the base branch
|
APKs built during tests are available here. Scroll down to Artifacts! |
…te_enrolling_fails-cherry-pick # Conflicts: # kalium
…te_enrolling_fails-cherry-pick
|
APKs built during tests are available here. Scroll down to Artifacts! |
alexandreferris
deleted the
fix/misleading_dialog_copy_when_certificate_enrolling_fails-cherry-pick
branch
|
Build 3725 succeeded. The build produced the following APK's: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry pick from the original PR:
kalium
PR Submission Checklist for internal contributors
The PR Title
The PR Description
What's new in this PR?
Issues
When E2EI is already enabled when the user logs in, he is forced to generate his certificate. If this certificate generation fails, we see the wrong copy dialog.
Solutions
Adjust dialog copy with correct information (correct subtext and removal of button)
Testing
How to Test
Attachments (Optional)
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References